#include "iredges.h"
#include "execfreq.h"
#include "irvrfy.h"
+#include "irbackedge_t.h"
#include <lpp/lpp.h>
#include <lpp/mps.h>
static int opt_remats = REMATS_ALL;
static int opt_repair_schedule = 0;
static int opt_no_enlarge_liveness = 0;
+static int opt_remat_while_live = 1;
static int opt_timeout = 300;
static double opt_cost_reload = 8.0;
static double opt_cost_memoperand = 7.0;
-static double opt_cost_spill = 50.0;
+static double opt_cost_spill = 15.0;
static double opt_cost_remat = 1.0;
};
static const lc_opt_table_entry_t options[] = {
- LC_OPT_ENT_ENUM_MASK("keepalive", "keep alive remats, spills or reloads", &keep_alive_var),
+ LC_OPT_ENT_ENUM_MASK("keepalive", "keep alive inserted nodes", &keep_alive_var),
LC_OPT_ENT_BOOL ("goodwin", "activate goodwin reduction", &opt_goodwin),
LC_OPT_ENT_BOOL ("memcopies", "activate memcopy handling", &opt_memcopies),
LC_OPT_ENT_BOOL ("memoperands", "activate memoperands", &opt_memoperands),
- LC_OPT_ENT_ENUM_INT ("remats", "type of remats to insert (none, briggs, noinverse or all)",&remats_var),
+ LC_OPT_ENT_ENUM_INT ("remats", "type of remats to insert", &remats_var),
LC_OPT_ENT_BOOL ("repair_schedule", "repair the schedule by rematting once used nodes",&opt_repair_schedule),
LC_OPT_ENT_BOOL ("no_enlage_liveness", "do not enlarge liveness of operands of remats",&opt_no_enlarge_liveness),
+ LC_OPT_ENT_BOOL ("remat_while_live", "only remat where rematted value was live", &opt_remat_while_live),
- LC_OPT_ENT_ENUM_MASK("dump", "dump problem, mps, solution, stats or pressure", &dump_var),
+ LC_OPT_ENT_ENUM_MASK("dump", "dump problem, solution or statistical data", &dump_var),
LC_OPT_ENT_BOOL ("log", "activate the lpp log", &opt_log),
LC_OPT_ENT_INT ("timeout", "ILP solver timeout", &opt_timeout),
set *interferences;
ir_node *m_unknown;
set *memoperands;
+#ifndef SCHEDULE_PHIM
+ pset *phims;
+#endif
DEBUG_ONLY(firm_dbg_module_t * dbg);
} spill_ilp_t;
return ((double)be_profile_get_block_execcount(get_block(irn))) + FUDGE;
#ifndef EXECFREQ_LOOPDEPH
- return get_block_execfreq(si->chordal_env->exec_freq, get_block(irn)) + FUDGE;
+ return get_block_execfreq(si->chordal_env->birg->exec_freq, get_block(irn)) + FUDGE;
#else
if(is_Block(irn))
return exp(get_loop_depth(get_irn_loop(irn)) * log(10)) + FUDGE;
remat = obstack_alloc(si->obst, sizeof(*remat));
remat->op = op;
- remat->cost = get_cost(si, op);
+ remat->cost = (int)get_cost(si, op);
remat->value = dest_value;
remat->proj = proj;
remat->inverse = 0;
sched_add_after(insert, irn);
}
+static ir_node *
+next_post_remat(const ir_node * irn)
+{
+ op_t *op;
+ ir_node *next;
+
+ if(is_Block(irn)) {
+ next = sched_block_first_nonphi(irn);
+ } else {
+ next = sched_next_op(irn);
+ }
+
+ if(sched_is_end(next))
+ return NULL;
+
+ op = get_irn_link(next);
+ if(op->is_remat && !op->attr.remat.pre) {
+ return next;
+ }
+
+ return NULL;
+}
+
+
+static ir_node *
+next_pre_remat(const spill_ilp_t * si, const ir_node * irn)
+{
+ op_t *op;
+ ir_node *ret;
+
+ if(is_Block(irn)) {
+ ret = sched_block_last_noncf(si, irn);
+ ret = sched_next(ret);
+ ret = sched_prev_op(ret);
+ } else {
+ ret = sched_prev_op(irn);
+ }
+
+ if(sched_is_end(ret) || is_Phi(ret))
+ return NULL;
+
+ op = (op_t*)get_irn_link(ret);
+ if(op->is_remat && op->attr.remat.pre) {
+ return ret;
+ }
+
+ return NULL;
+}
+
/**
* Tells you whether a @p remat can be placed before the irn @p pos
*/
}
}
}
+ /*
+ * find values that are used by remats at end of block
+ * and insert them into live set
+ */
+ foreach_pre_remat(si, bb, irn) {
+ int n;
+
+ for (n=get_irn_arity(irn)-1; n>=0; --n) {
+ ir_node *remat_arg = get_irn_n(irn, n);
+
+ if(!has_reg_class(si, remat_arg)) continue;
+
+ /* if value is becoming live through use by remat */
+ if(!pset_find_ptr(live, remat_arg)) {
+ DBG((si->dbg, LEVEL_4, " value %+F becoming live through use by remat at end of block %+F\n", remat_arg, irn));
+
+ pset_insert_ptr(live, remat_arg);
+ }
+ }
+ }
}
static void
if(!pset_find_ptr(args, remat->value)) {
DBG((si->dbg, LEVEL_4, "\t considering remat %+F with arg %+F\n", remat->op, arg));
- /* only remat values that can be used be real ops */
- if(pset_find_ptr(live, remat->value)) {
+ /* only remat values that can be used by real ops */
+ if(!opt_remat_while_live || pset_find_ptr(live, remat->value)) {
pset_insert_ptr(post_remats, remat);
}
}
DBG((si->dbg, LEVEL_4, "\t considering remat2 %+F at beginning of block %+F\n", remat->op, bb));
/* put the remat here if all its args are available and result is still live */
- if(pset_find_ptr(live_in, remat->value)) {
+ if(!opt_remat_while_live || pset_find_ptr(live_in, remat->value)) {
pset_insert_ptr(post_remats, remat);
}
}
pset_insert_ptr(live, irn);
}
}
+ /*
+ * find values that are used by remats at end of block
+ * and insert them into live set
+ */
+ foreach_pre_remat(si, bb, irn) {
+ int n;
+
+ for (n=get_irn_arity(irn)-1; n>=0; --n) {
+ ir_node *remat_arg = get_irn_n(irn, n);
+
+ if(has_reg_class(si, remat_arg)) {
+ pset_insert_ptr(live, remat_arg);
+ }
+ }
+ }
/* collect values used by cond jumps etc. at bb end (use_end) -> always live */
/* their reg_out must always be set */
ir_snprintf(buf, sizeof(buf), "reg_out_%N_%N", irn, bb);
spill->reg_out = lpp_add_var_default(si->lpp, buf, lpp_binary, 0.0, 1.0);
- /* if irn is used at the end of the block, then it is live anyway */
- //lpp_set_factor_fast(si->lpp, cst, spill->reg_out, 1.0);
ir_snprintf(buf, sizeof(buf), "mem_out_%N_%N", irn, bb);
spill->mem_out = lpp_add_var_default(si->lpp, buf, lpp_binary, 0.0, 1.0);
del_pset(use_end);
}
-static ir_node *
-next_post_remat(const ir_node * irn)
-{
- op_t *op;
- ir_node *next;
-
- if(is_Block(irn)) {
- next = sched_block_first_nonphi(irn);
- } else {
- next = sched_next_op(irn);
- }
-
- if(sched_is_end(next))
- return NULL;
-
- op = get_irn_link(next);
- if(op->is_remat && !op->attr.remat.pre) {
- return next;
- }
-
- return NULL;
-}
-
-
-static ir_node *
-next_pre_remat(const spill_ilp_t * si, const ir_node * irn)
-{
- op_t *op;
- ir_node *ret;
-
- if(is_Block(irn)) {
- ret = sched_block_last_noncf(si, irn);
- ret = sched_next(ret);
- ret = sched_prev_op(ret);
- } else {
- ret = sched_prev_op(irn);
- }
-
- if(sched_is_end(ret) || is_Phi(ret))
- return NULL;
-
- op = (op_t*)get_irn_link(ret);
- if(op->is_remat && op->attr.remat.pre) {
- return ret;
- }
-
- return NULL;
-}
-
/**
* Find a remat of value @p value in the epilog of @p pos
*/
insert_mem_copy_position(si, live, bb);
/*
- * start new live ranges for values used by remats at end of block
- * and assure the remat args are available
+ * assure the remat args are available
*/
foreach_pre_remat(si, bb, tmp) {
op_t *remat_op = get_irn_link(tmp);
for (n=get_irn_arity(tmp)-1; n>=0; --n) {
ir_node *remat_arg = get_irn_n(tmp, n);
op_t *arg_op = get_irn_link(remat_arg);
- ilp_var_t prev_lr;
if(!has_reg_class(si, remat_arg)) continue;
- /* if value is becoming live through use by remat */
- if(!pset_find_ptr(live, remat_arg)) {
- ir_snprintf(buf, sizeof(buf), "lr_%N_end%N", remat_arg, bb);
- prev_lr = lpp_add_var_default(si->lpp, buf, lpp_binary, 0.0, 0.0);
-
- arg_op->attr.live_range.ilp = prev_lr;
- arg_op->attr.live_range.op = bb;
-
- DBG((si->dbg, LEVEL_4, " value %+F becoming live through use by remat at end of block %+F\n", remat_arg, tmp));
+ spill = set_find_spill(spill_bb->ilp, remat_arg);
+ assert(spill);
- pset_insert_ptr(live, remat_arg);
- add_to_spill_bb(si, bb, remat_arg);
- }
+ /* arguments of remats have to be live until the very end of the block
+ * remat = reg_out(remat_arg) and (reload(remat_arg) or live_range(remat_arg)),
+ * no remats, they could be in wrong order
+ */
- /* remat <= live_rang(remat_arg) [ + reload(remat_arg) ] */
ir_snprintf(buf, sizeof(buf), "req_remat_%N_arg_%N", tmp, remat_arg);
cst = lpp_add_cst(si->lpp, buf, lpp_less, 0.0);
- lpp_set_factor_fast(si->lpp, cst, remat_op->attr.remat.ilp, 1.0);
+ lpp_set_factor_fast(si->lpp, cst, remat_op->attr.remat.ilp, 3.0);
+ lpp_set_factor_fast(si->lpp, cst, spill->reg_out, -2.0);
lpp_set_factor_fast(si->lpp, cst, arg_op->attr.live_range.ilp, -1.0);
/* use reload placed for this argument */
#endif
}
} else {
+#if 0
pset_foreach(defs, tmp) {
op_t *tmp_op = get_irn_link(tmp);
spill_t *spill = set_find_spill(spill_bb->ilp, tmp);
lpp_set_factor_fast(si->lpp, cst, tmp_op->attr.live_range.ilp, 1.0);
lpp_set_factor_fast(si->lpp, cst, spill->spill, 1.0);
}
+#endif
}
/** insert a spill at an arbitrary position */
ir_node *be_spill2(const arch_env_t *arch_env, ir_node *irn, ir_node *insert)
{
- ir_node *bl = is_Block(insert)?insert:get_nodes_block(insert);
+ ir_node *bl = is_Block(insert)?insert:get_nodes_block(insert);
ir_graph *irg = get_irn_irg(bl);
- ir_node *frame = get_irg_frame(irg);
- ir_node *spill;
- ir_node *next;
-
- const arch_register_class_t *cls = arch_get_irn_reg_class(arch_env, irn, -1);
- const arch_register_class_t *cls_frame = arch_get_irn_reg_class(arch_env, frame, -1);
+ ir_node *frame = get_irg_frame(irg);
+ ir_node *spill;
+ ir_node *next;
+ const arch_register_class_t *cls = arch_get_irn_reg_class(arch_env, irn, -1);
- spill = be_new_Spill(cls, cls_frame, irg, bl, frame, irn);
+ spill = be_new_Spill(cls, irg, bl, irn);
/*
* search the right insertion point. a spill of a phi cannot be put
* which is its default initialization (see above).
*/
- if(bl == get_irg_start_block(irg) && sched_get_time_step(frame) >= sched_get_time_step(insert))
+ if (bl == get_irg_start_block(irg) && sched_get_time_step(frame) >= sched_get_time_step(insert))
insert = frame;
for (next = sched_next(insert); is_Phi(next) || is_Proj(next); next = sched_next(insert))
return spills;
}
+static ir_node *
+new_r_PhiM_nokeep(ir_graph * irg, ir_node *block, int arity, ir_node **in)
+{
+ ir_node *res;
+
+ assert( get_irn_arity(block) == arity );
+
+ res = new_ir_node(NULL, irg, block, op_Phi, mode_M, arity, in);
+ res->attr.phi_backedge = new_backedge_arr(irg->obst, arity);
+
+ return res;
+}
+
/**
* @param before The node after which the spill will be placed in the schedule
*/
ins[n] = si->m_unknown;
}
- mem_phi = new_r_Phi(si->chordal_env->irg, get_nodes_block(phi), get_irn_arity(phi), ins, mode_M);
+ mem_phi = new_r_PhiM_nokeep(si->chordal_env->irg, get_nodes_block(phi), get_irn_arity(phi), ins);
defs = set_insert_def(si->values, phi);
assert(defs);
#ifdef SCHEDULE_PHIM
sched_add_after(phi, mem_phi);
+#else
+ pset_insert_ptr(si->phims, mem_phi);
#endif
if(opt_keep_alive & KEEPALIVE_SPILLS)
reload = insert_reload(si, arg, insert_pos);
+ assert(reload && "no reload returned");
set_irn_n(irn, n, reload);
if(opt_keep_alive & KEEPALIVE_RELOADS)
}
}
+#ifndef SCHEDULE_PHIM
+static void
+kill_unused_phims(spill_ilp_t * si, struct kill_helper * kh)
+{
+ ir_node *phi;
+ ir_node *bad = get_irg_bad(si->chordal_env->irg);
+ int n;
+
+ pset_foreach(si->phims, phi) {
+ if(!bitset_is_set(kh->used, get_irn_idx(phi))) {
+
+ set_nodes_block(phi, bad);
+ for (n=get_irn_arity(phi)-1; n>=0; --n) {
+ set_irn_n(phi, n, bad);
+ }
+ }
+ }
+}
+#endif
+
static void
kill_all_unused_values_in_schedule(spill_ilp_t * si)
{
- struct kill_helper kh;
+ struct kill_helper kh;
kh.used = bitset_malloc(get_irg_last_idx(si->chordal_env->irg));
kh.si = si;
irg_walk_graph(si->chordal_env->irg, walker_collect_used, NULL, kh.used);
+#ifndef SCHEDULE_PHIM
+ kill_unused_phims(si, &kh);
+#endif
irg_block_walk_graph(si->chordal_env->irg, walker_kill_unused, NULL, &kh);
bitset_free(kh.used);
static void
rewire_uses(spill_ilp_t * si)
{
- dom_front_info_t *dfi = be_compute_dominance_frontiers(si->chordal_env->irg);
defs_t *defs;
pset *ignore = pset_new_ptr(1);
+ be_dom_front_info_t *dom_front = si->chordal_env->birg->dom_front;
pset_insert_ptr(ignore, get_irg_end(si->chordal_env->irg));
// print_irn_pset(spills);
// print_irn_pset(reloads);
- be_ssa_constr_set_ignore(dfi, si->lv, spills, ignore);
+ be_ssa_constr_set_ignore(dom_front, si->lv, spills, ignore);
}
del_pset(reloads);
}
DBG((si->dbg, LEVEL_4, "\t %d new definitions for value %+F\n", pset_count(nodes)-orig_kept, defs->value));
- be_ssa_constr_set(dfi, si->lv, nodes);
+ be_ssa_constr_set(dom_front, si->lv, nodes);
del_pset(nodes);
}
}
// remove_unused_defs(si);
-
- be_free_dominance_frontiers(dfi);
}
char dump_suffix2[256];
struct obstack obst;
spill_ilp_t si;
+ be_irg_t *birg = chordal_env->birg;
ir_snprintf(problem_name, sizeof(problem_name), "%F_%s", chordal_env->irg, chordal_env->cls->name);
ir_snprintf(dump_suffix, sizeof(dump_suffix), "-%s-remats", chordal_env->cls->name);
if(opt_verify & VERIFY_DOMINANCE)
be_check_dominance(chordal_env->irg);
+ be_assure_dom_front(birg);
+ be_assure_liveness(birg);
+
obstack_init(&obst);
si.chordal_env = chordal_env;
si.obst = &obst;
si.all_possible_remats = pset_new_ptr_default();
si.spills = pset_new_ptr_default();
si.inverse_ops = pset_new_ptr_default();
- si.lv = chordal_env->lv;
+ si.lv = birg->lv;
si.keep = NULL;
si.n_regs = get_n_regs(&si);
assert(lpp_is_sol_valid(si.lpp)
&& "solution of ILP must be valid");
- DBG((si.dbg, LEVEL_1, "\t%s: iterations: %d, solution time: %g, objective function: %g\n", problem_name, si.lpp->iterations, si.lpp->sol_time, is_zero(si.lpp->objval)?0.0:si.lpp->objval));
+ DBG((si.dbg, LEVEL_1, "\t%s: iterations: %d, solution time: %g, objective function: %g, best bound: %g\n", problem_name, si.lpp->iterations, si.lpp->sol_time, is_zero(si.lpp->objval)?0.0:si.lpp->objval, is_zero(si.lpp->best_bound)?0.0:si.lpp->best_bound));
if(opt_dump_flags & DUMP_SOLUTION) {
FILE *f;
}
}
+#ifndef SCHEDULE_PHIM
+ si.phims = pset_new_ptr_default();
+#endif
writeback_results(&si);
+
#endif /* SOLVE */
kill_all_unused_values_in_schedule(&si);
+#if !defined(SCHEDULE_PHIM) && defined(SOLVE)
+ del_pset(si.phims);
+#endif
+
if(opt_keep_alive & (KEEPALIVE_SPILLS | KEEPALIVE_RELOADS))
be_dump(chordal_env->irg, "-spills-placed", dump_ir_block_graph);