#include "irnode_t.h"
#include "ircons_t.h"
#include "irloop_t.h"
-#include "phiclass.h"
+#include "phiclass_t.h"
#include "iredges.h"
#include "execfreq.h"
#define REMAT_WHILE_LIVE /* only remat values that are live */
//#define NO_ENLARGE_L1V3N355 /* do not remat after the death of some operand */
//#define EXECFREQ_LOOPDEPH /* compute execution frequency from loop depth only */
-//#define MAY_DIE_AT_PRE_REMAT /* allow values to die after a pre remat */
-#define CHECK_POST_REMAT /* check pressure after post remats (conservative but otherwise we can temporarily exceed the register pressure) */
+#define MAY_DIE_AT_REMAT /* allow values to die after a pre remat */
#define NO_SINGLE_USE_REMATS /* do not repair schedule */
//#define KEEPALIVE_SPILLS
//#define KEEPALIVE_RELOADS
#define GOODWIN_REDUCTION
-#define NO_MEMCOPIES
+//#define NO_MEMCOPIES
#define SOLVE
//#define SOLVE_LOCAL
static INLINE int
is_rematerializable(const spill_ilp_t * si, const ir_node * irn)
{
- int i,
- n;
+ int n;
const arch_env_t *arch_env = si->chordal_env->birg->main_env->arch_env;
int remat = (arch_irn_get_flags(arch_env, irn) & arch_irn_flags_rematerializable) != 0;
ir_fprintf(stderr, " Node %+F is not rematerializable\n", irn);
#endif
- for (i = 0, n = get_irn_arity(irn); i < n && remat; ++i) {
- ir_node *op = get_irn_n(irn, i);
+ for (n = get_irn_arity(irn)-1; n>=0 && remat; --n) {
+ ir_node *op = get_irn_n(irn, n);
remat &= has_reg_class(si, op) || arch_irn_get_flags(arch_env, op) & arch_irn_flags_ignore || (get_irn_op(op) == op_NoMem);
// if(!remat)
remat->inverse = 0;
} else {
arch_inverse_t inverse;
- int i,
- n;
+ int n;
/* get the index of the operand we want to retrieve by the inverse op */
- for (i = 0, n = get_irn_arity(op); i < n; ++i) {
- ir_node *arg = get_irn_n(op, i);
+ for (n = get_irn_arity(op)-1; n>=0; --n) {
+ ir_node *arg = get_irn_n(op, n);
if(arg == dest_value) break;
}
- if(i == n) return NULL;
+ if(n<0) return NULL;
- DBG((si->dbg, LEVEL_5, "\t requesting inverse op for argument %d of op %+F\n", i, op));
+ DBG((si->dbg, LEVEL_5, "\t requesting inverse op for argument %d of op %+F\n", n, op));
/* else ask the backend to give an inverse op */
- if(arch_get_inverse(si->chordal_env->birg->main_env->arch_env, op, i, &inverse, si->obst)) {
+ if(arch_get_inverse(si->chordal_env->birg->main_env->arch_env, op, n, &inverse, si->obst)) {
int i;
DBG((si->dbg, LEVEL_4, "\t backend gave us an inverse op with %d nodes and cost %d\n", inverse.n, inverse.costs));
assert(inverse.n > 0 && "inverse op should have at least one node");
- for(i=0; i<inverse.n; ++i) {
+ for(i=inverse.n-1; i>=0; --i) {
pset_insert_ptr(si->inverse_ops, inverse.nodes[i]);
}
{
remat_info_t *remat_info,
query;
- int i,
- n;
+ int n;
assert(remat->op);
assert(remat->value);
pset_insert(remat_info->remats, remat, HASH_PTR(remat->op));
/* insert the remat into the remats_be_operand set of each argument of the remat op */
- for (i = 0, n = get_irn_arity(remat->op); i < n; ++i) {
- ir_node *arg = get_irn_n(remat->op, i);
+ for (n = get_irn_arity(remat->op)-1; n>=0; --n) {
+ ir_node *arg = get_irn_n(remat->op, n);
query.irn = arg;
query.remats = NULL;
static INLINE void
get_remats_from_op(spill_ilp_t * si, const ir_node * op)
{
- int i,
- n;
+ int n;
remat_t *remat;
#ifdef NO_SINGLE_USE_REMATS
#ifdef COLLECT_INVERSE_REMATS
/* repeat the whole stuff for each remat retrieved by get_remat_from_op(op, arg)
for each arg */
- for (i = 0, n = get_irn_arity(op); i < n; ++i) {
- ir_node *arg = get_irn_n(op, i);
+ for (n = get_irn_arity(op)-1; n>=0; --n) {
+ ir_node *arg = get_irn_n(op, n);
if(has_reg_class(si, arg)) {
/* try to get an inverse remat */
{
const ir_node *op = remat->op;
const ir_node *prev;
- int i,
- n,
+ int n,
res = 1;
if(is_Block(pos)) {
}
#endif
- for(i=0, n=get_irn_arity(op); i<n && res; ++i) {
- const ir_node *arg = get_irn_n(op, i);
+ for(n=get_irn_arity(op)-1; n>=0 && res; --n) {
+ const ir_node *arg = get_irn_n(op, n);
#ifdef NO_ENLARGE_L1V3N355
if(has_reg_class(si, arg) && live) {
bb = is_Block(pos)?pos:get_nodes_block(pos);
copy = exact_copy(irn);
+
+ _set_phi_class(copy, NULL);
set_nodes_block(copy, bb);
sched_put_before(si, pos, copy);
bb = is_Block(pos)?pos:get_nodes_block(pos);
copy = exact_copy(irn);
+
+ _set_phi_class(copy, NULL);
set_nodes_block(copy, bb);
sched_put_after(pos, copy);
return copy;
}
-static void
+static ir_node *
insert_remat_after(spill_ilp_t * si, const remat_t * remat, const ir_node * pos, const pset * live)
{
char buf[256];
copy = insert_copy_after(si, remat->op, pos);
-// ir_snprintf(buf, sizeof(buf), "remat2_%N_%N", remat->value, pos);
ir_snprintf(buf, sizeof(buf), "remat2_%N_%N", copy, pos);
op = obstack_alloc(si->obst, sizeof(*op));
op->is_remat = 1;
} else {
proj_copy = NULL;
}
+
+ return copy;
}
+
+ return NULL;
}
-static void
+static ir_node *
insert_remat_before(spill_ilp_t * si, const remat_t * remat, const ir_node * pos, const pset * live)
{
char buf[256];
copy = insert_copy_before(si, remat->op, pos);
-// ir_snprintf(buf, sizeof(buf), "remat_%N_%N", remat->value, pos);
ir_snprintf(buf, sizeof(buf), "remat_%N_%N", copy, pos);
op = obstack_alloc(si->obst, sizeof(*op));
op->is_remat = 1;
} else {
proj_copy = NULL;
}
+
+ return copy;
}
+
+ return NULL;
}
static int
op_t *op;
pset *args;
ir_node *arg;
+ pset *remat_args;
next = sched_prev(irn);
pset_insert_ptr(live, arg);
}
}
+ /* delete defined value from live set */
+ if(has_reg_class(si, irn)) {
+ pset_remove_ptr(live, irn);
+ }
- /* insert all possible remats after irn */
+
+ remat_args = pset_new_ptr_default();
+
+ /* insert all possible remats before irn */
pset_foreach(args, arg) {
remat_info_t *remat_info,
query;
remat_t *remat;
- /* continue if the operand has the wrong reg class */
+ /* continue if the operand has the wrong reg class
+ */
if(!has_reg_class(si, arg))
continue;
continue;
}
- /* do not place post remats after jumps */
- if(sched_skip_cf_predicator(irn, si->chordal_env->birg->main_env->arch_env)) continue;
+ if(remat_info->remats) {
+ pset_foreach(remat_info->remats, remat) {
+ ir_node *remat_irn = NULL;
- if(remat_info->remats_by_operand) {
- pset_foreach(remat_info->remats_by_operand, remat) {
- /* do not insert remats producing the same value as one of the operands */
- if(!pset_find_ptr(args, remat->value)) {
- DBG((si->dbg, LEVEL_4, "\t considering remat %+F with arg %+F\n", remat->op, arg));
+ DBG((si->dbg, LEVEL_4, "\t considering remat %+F for arg %+F\n", remat->op, arg));
#ifdef REMAT_WHILE_LIVE
- if(pset_find_ptr(live, remat->value)) {
- insert_remat_after(si, remat, irn, live);
- }
+ if(pset_find_ptr(live, remat->value)) {
+ remat_irn = insert_remat_before(si, remat, irn, live);
+ }
#else
- insert_remat_after(si, remat, irn, live);
+ remat_irn = insert_remat_before(si, remat, irn, live);
#endif
+ if(remat_irn) {
+ for(n=get_irn_arity(remat_irn)-1; n>=0; --n) {
+ ir_node *remat_arg = get_irn_n(remat_irn, n);
+
+ if(!has_reg_class(si, remat_arg)) continue;
+
+ pset_insert_ptr(remat_args, remat_arg);
+ }
}
}
}
}
- /* delete defined value from live set */
- if(has_reg_class(si, irn)) {
- pset_remove_ptr(live, irn);
+ /* now we add remat args to op's args because they could also die at this op */
+ pset_foreach(args,arg) {
+ if(pset_find_ptr(remat_args, arg)) {
+ pset_remove_ptr(remat_args, arg);
+ }
+ }
+ pset_foreach(remat_args,arg) {
+ pset_insert_ptr(args, arg);
}
- /* insert all possible remats before irn */
+ /* insert all possible remats after irn */
pset_foreach(args, arg) {
remat_info_t *remat_info,
query;
remat_t *remat;
- /* continue if the operand has the wrong reg class
- */
+ /* continue if the operand has the wrong reg class */
if(!has_reg_class(si, arg))
continue;
continue;
}
- if(remat_info->remats) {
- pset_foreach(remat_info->remats, remat) {
- DBG((si->dbg, LEVEL_4, "\t considering remat %+F for arg %+F\n", remat->op, arg));
+ /* do not place post remats after jumps */
+ if(sched_skip_cf_predicator(irn, si->chordal_env->birg->main_env->arch_env)) continue;
+
+ if(remat_info->remats_by_operand) {
+ pset_foreach(remat_info->remats_by_operand, remat) {
+ /* do not insert remats producing the same value as one of the operands */
+ if(!pset_find_ptr(args, remat->value)) {
+ DBG((si->dbg, LEVEL_4, "\t considering remat %+F with arg %+F\n", remat->op, arg));
#ifdef REMAT_WHILE_LIVE
- if(pset_find_ptr(live, remat->value)) {
- insert_remat_before(si, remat, irn, live);
- }
+ if(pset_find_ptr(live, remat->value)) {
+ insert_remat_after(si, remat, irn, live);
+ }
#else
- insert_remat_before(si, remat, irn, live);
+ insert_remat_after(si, remat, irn, live);
#endif
+ }
}
}
}
+ del_pset(remat_args);
del_pset(args);
irn = next;
}
}
}
+/**
+ * Inserts ILP-constraints and variables for memory copying before the given position
+ */
+static void
+insert_mem_copy_position(spill_ilp_t * si, pset * live, const ir_node * block)
+{
+ const ir_node *succ;
+ const ir_edge_t *edge;
+ spill_bb_t *spill_bb = get_irn_link(block);
+ ir_node *phi;
+ int pos;
+ ilp_cst_t cst;
+ ilp_var_t copyreg;
+ char buf[256];
+ ir_node *tmp;
+
+
+ assert(edges_activated(current_ir_graph));
+
+ edge = get_block_succ_first(block);
+ if(!edge) return;
+
+ succ = edge->src;
+ pos = edge->pos;
+
+ edge = get_block_succ_next(block, edge);
+ /* next block can only contain phis, if this is a merge edge */
+ if(edge) return;
+
+ ir_snprintf(buf, sizeof(buf), "copyreg_%N", block);
+ copyreg = lpp_add_var(si->lpp, buf, lpp_binary, 0.0);
+
+ ir_snprintf(buf, sizeof(buf), "check_copyreg_%N", block);
+ cst = lpp_add_cst(si->lpp, buf, lpp_less, si->n_regs);
+
+ pset_foreach(live, tmp) {
+ spill_t *spill;
+#if 0
+ op_t *op = get_irn_link(irn);
+ lpp_set_factor_fast(si->lpp, cst, op->attr.live_range.ilp, 1.0);
+#endif
+ spill = set_find_spill(spill_bb->ilp, tmp);
+ assert(spill);
+
+ lpp_set_factor_fast(si->lpp, cst, spill->reg_out, 1.0);
+ }
+ lpp_set_factor_fast(si->lpp, cst, copyreg, 1.0);
+
+ sched_foreach(succ, phi) {
+ const ir_node *to_copy;
+ op_t *to_copy_op;
+ spill_t *to_copy_spill;
+ op_t *phi_op = get_irn_link(phi);
+ ilp_var_t reload = ILP_UNDEF;
+
+
+ if(!is_Phi(phi)) break;
+ if(!has_reg_class(si, phi)) continue;
+
+ to_copy = get_irn_n(phi, pos);
+
+ to_copy_op = get_irn_link(to_copy);
+
+ to_copy_spill = set_find_spill(spill_bb->ilp, to_copy);
+ assert(to_copy_spill);
+
+ if(spill_bb->reloads) {
+ keyval_t *keyval = set_find_keyval(spill_bb->reloads, to_copy);
+
+ if(keyval) {
+ reload = PTR_TO_INT(keyval->val);
+ }
+ }
+
+ ir_snprintf(buf, sizeof(buf), "req_copy_%N_%N", block, to_copy);
+ cst = lpp_add_cst(si->lpp, buf, lpp_less, 0.0);
+
+ /* copy - reg_out - reload - remat - live_range <= 0 */
+ lpp_set_factor_fast(si->lpp, cst, phi_op->attr.live_range.args.copies[pos], 1.0);
+ lpp_set_factor_fast(si->lpp, cst, to_copy_spill->reg_out, -1.0);
+ if(reload != ILP_UNDEF) lpp_set_factor_fast(si->lpp, cst, reload, -1.0);
+ lpp_set_factor_fast(si->lpp, cst, to_copy_op->attr.live_range.ilp, -1.0);
+ foreach_pre_remat(si, block, tmp) {
+ op_t *remat_op = get_irn_link(tmp);
+ if(remat_op->attr.remat.remat->value == to_copy) {
+ lpp_set_factor_fast(si->lpp, cst, remat_op->attr.remat.ilp, -1.0);
+ }
+ }
+
+ ir_snprintf(buf, sizeof(buf), "copyreq_%N_%N", block, to_copy);
+ cst = lpp_add_cst(si->lpp, buf, lpp_less, 0.0);
+
+ /* copy - reg_out - copyreg <= 0 */
+ lpp_set_factor_fast(si->lpp, cst, phi_op->attr.live_range.args.copies[pos], 1.0);
+ lpp_set_factor_fast(si->lpp, cst, to_copy_spill->reg_out, -1.0);
+ lpp_set_factor_fast(si->lpp, cst, copyreg, -1.0);
+ }
+}
+
+
/**
* Walk all irg blocks and emit this ILP
*/
char buf[256];
ilp_cst_t cst;
spill_bb_t *spill_bb = get_irn_link(bb);
- int i;
ir_node *tmp;
spill_t *spill;
- irn_live_t *li;
pset *defs = pset_new_ptr_default();
/* maybe we should also assure that reg_out >= live_range etc. */
}
+#ifndef NO_MEMCOPIES
+ insert_mem_copy_position(si, live, bb);
+#endif
+
/*
* start new live ranges for values used by remats at end of block
* and assure the remat args are available
d = 0;
ilp_cst_t check_pre,
check_post;
-#ifdef CHECK_POST_REMAT
- ilp_cst_t check_post_remat;
-#endif
set *args;
+ pset *used;
+ pset *remat_defs;
keyval_t *keyval;
/* iterate only until first phi */
/* skip projs */
if(is_Proj(irn)) continue;
-#if 0
- /* remove defined values from live set */
- if(has_reg_class(si, irn)) {
- assert(pset_find_ptr(live, irn));
- pset_remove_ptr(live, irn);
- }
-#endif
+ /*
+ * init set of irn's arguments
+ * and all possibly used values around this op
+ * and values defined by post remats
+ */
+ args = new_set(cmp_keyval, get_irn_arity(irn));
+ used = pset_new_ptr(pset_count(live) + get_irn_arity(irn));
+ remat_defs = pset_new_ptr(pset_count(live));
- /* init set of irn's arguments */
- args = new_set(cmp_keyval, get_irn_arity(irn));
for (n=get_irn_arity(irn)-1; n>=0; --n) {
ir_node *irn_arg = get_irn_n(irn, n);
if(has_reg_class(si, irn_arg)) {
set_insert_keyval(args, irn_arg, (void*)n);
+ pset_insert_ptr(used, irn_arg);
+ }
+ }
+ foreach_post_remat(irn, tmp) {
+ op_t *remat_op = get_irn_link(tmp);
+
+ pset_insert_ptr(remat_defs, remat_op->attr.remat.remat->value);
+
+ for (n=get_irn_arity(tmp)-1; n>=0; --n) {
+ ir_node *remat_arg = get_irn_n(tmp, n);
+ if(has_reg_class(si, remat_arg)) {
+ pset_insert_ptr(used, remat_arg);
+ }
+ }
+ }
+ foreach_pre_remat(si, irn, tmp) {
+ for (n=get_irn_arity(tmp)-1; n>=0; --n) {
+ ir_node *remat_arg = get_irn_n(tmp, n);
+ if(has_reg_class(si, remat_arg)) {
+ pset_insert_ptr(used, remat_arg);
+ }
}
}
* I N E P I L O G O F irn
**********************************/
+ /* ensure each dying value is used by only one post remat */
+ pset_foreach(live, tmp) {
+ ir_node *value = tmp;
+ op_t *value_op = get_irn_link(value);
+ ir_node *remat;
+ int n_remats = 0;
+
+ cst = ILP_UNDEF;
+ foreach_post_remat(irn, remat) {
+ op_t *remat_op = get_irn_link(remat);
+
+ for(n=get_irn_arity(remat)-1; n>=0; --n) {
+ ir_node *remat_arg = get_irn_n(remat, n);
+
+ /* if value is used by this remat add it to constraint */
+ if(remat_arg == value) {
+ if(n_remats == 0) {
+ /* sum remat2s <= 1 + n_remats*live_range */
+ ir_snprintf(buf, sizeof(buf), "dying_lr_%N_%N", value, irn);
+ cst = lpp_add_cst(si->lpp, buf, lpp_less, 1.0);
+ }
+
+ n_remats++;
+ lpp_set_factor_fast(si->lpp, cst, remat_op->attr.remat.ilp, 1.0);
+ break;
+ }
+ }
+ }
+
+ if(value_op->attr.live_range.ilp != ILP_UNDEF && cst != ILP_UNDEF) {
+ lpp_set_factor_fast(si->lpp, cst, value_op->attr.live_range.ilp, -n_remats);
+ }
+ }
+
+
+
/* new live ranges for values from L\U defined by post remats */
pset_foreach(live, tmp) {
- ir_node *value = tmp;//remat_op->attr.remat.remat->value;
+ ir_node *value = tmp;
op_t *value_op = get_irn_link(value);
if(!set_find_keyval(args, value) && !pset_find_ptr(defs, value)) {
ilp_var_t prev_lr = ILP_UNDEF;
ir_node *remat;
- cst = ILP_UNDEF;
- foreach_post_remat(irn, remat) {
- op_t *remat_op = get_irn_link(remat);
+ if(pset_find_ptr(remat_defs, value)) {
- /* if value is being rematerialized by this remat */
- if(value == remat_op->attr.remat.remat->value) {
- if(cst == ILP_UNDEF) {
- /* next_live_range <= prev_live_range + sum remat2s */
- ir_snprintf(buf, sizeof(buf), "next_lr_%N_%N", value, irn);
- cst = lpp_add_cst(si->lpp, buf, lpp_less, 0.0);
+ /* next_live_range <= prev_live_range + sum remat2s */
+ ir_snprintf(buf, sizeof(buf), "next_lr_%N_%N", value, irn);
+ cst = lpp_add_cst(si->lpp, buf, lpp_less, 0.0);
- ir_snprintf(buf, sizeof(buf), "lr_%N_%N", value, irn);
- prev_lr = lpp_add_var(si->lpp, buf, lpp_binary, 0.0);
+ ir_snprintf(buf, sizeof(buf), "lr_%N_%N", value, irn);
+ prev_lr = lpp_add_var(si->lpp, buf, lpp_binary, 0.0);
- lpp_set_factor_fast(si->lpp, cst, value_op->attr.live_range.ilp, 1.0);
- lpp_set_factor_fast(si->lpp, cst, prev_lr, -1.0);
- }
+ lpp_set_factor_fast(si->lpp, cst, value_op->attr.live_range.ilp, 1.0);
+ lpp_set_factor_fast(si->lpp, cst, prev_lr, -1.0);
- lpp_set_factor_fast(si->lpp, cst, remat_op->attr.remat.ilp, -1.0);
+ foreach_post_remat(irn, remat) {
+ op_t *remat_op = get_irn_link(remat);
+
+ /* if value is being rematerialized by this remat */
+ if(value == remat_op->attr.remat.remat->value) {
+ lpp_set_factor_fast(si->lpp, cst, remat_op->attr.remat.ilp, -1.0);
+ }
}
- }
- if(prev_lr != ILP_UNDEF) {
value_op->attr.live_range.ilp = prev_lr;
value_op->attr.live_range.op = irn;
}
}
}
- /* requirements for post remats and start live ranges from L/U for values dying here */
+ /* requirements for post remats and start live ranges from L/U' for values dying here */
foreach_post_remat(irn, tmp) {
op_t *remat_op = get_irn_link(tmp);
int n;
if(!has_reg_class(si, remat_arg)) continue;
/* only for values in L\U (TODO and D?), the others are handled with post_use */
- if(!set_find_keyval(args, remat_arg)) {
+ if(!pset_find_ptr(used, remat_arg)) {
/* remat <= live_rang(remat_arg) */
ir_snprintf(buf, sizeof(buf), "req_remat2_%N_arg_%N", tmp, remat_arg);
cst = lpp_add_cst(si->lpp, buf, lpp_less, 0.0);
}
}
-#ifdef CHECK_POST_REMAT
- /* check the register pressure after the epilog */
- ir_snprintf(buf, sizeof(buf), "check_post_remat_%N", irn);
- check_post_remat = lpp_add_cst(si->lpp, buf, lpp_less, si->n_regs);
-
- /* iterate over L\U */
- pset_foreach(live, tmp) {
- if(!set_find_keyval(args, tmp)) {
- /* if a live value is not used by irn */
- tmp_op = get_irn_link(tmp);
- lpp_set_factor_fast(si->lpp, check_post_remat, tmp_op->attr.live_range.ilp, 1.0);
- }
- }
- /* iterate over remats in epilog and remove possibly defined values again from check_post_remat */
- foreach_post_remat(irn, tmp) {
- op_t *remat_op = get_irn_link(tmp);
- const ir_node *value = remat_op->attr.remat.remat->value;
- op_t *val_op = get_irn_link(value);
-
- assert(remat_op->is_remat && !remat_op->attr.remat.pre);
-
- /* values that are defined by remats are not counted */
-#ifdef REMAT_WHILE_LIVE
- assert(val_op->attr.live_range.ilp);
- lpp_set_factor_fast(si->lpp, check_post_remat, val_op->attr.live_range.ilp, 0.0);
-#else
- if(val_op->attr.live_range.ilp != ILP_UNDEF) {
- lpp_set_factor_fast(si->lpp, check_post_remat, val_op->attr.live_range.ilp, 0.0);
- }
-#endif /* REMAT_WHILE_LIVE */
-
- /* instead add these post remats to the check */
- lpp_set_factor_fast(si->lpp, check_post_remat, remat_op->attr.remat.ilp, 1.0);
- }
-
-#if 0 /* defs are still in live */
- /* get count of values in my register class defined by irn */
- /* also add defined values to check_post_remat; do this before iterating over args */
- pset_foreach(defs,tmp) {
- op_t *def_op = get_irn_link(tmp);
-
- lpp_set_factor_fast(si->lpp, check_post_remat, def_op->attr.live_range.ilp, 1.0);
- }
-#endif
-#endif /* CHECK_POST_REMAT */
-
-
d = pset_count(defs);
DBG((si->dbg, LEVEL_4, "\t %+F produces %d values in my register class\n", irn, d));
/* check the register pressure in the epilog */
- /* sum_{L\U} lr + sum_{U} post_use <= k - |D| */
+ /* sum_{L\U'} lr + sum_{U'} post_use <= k - |D| */
ir_snprintf(buf, sizeof(buf), "check_post_%N", irn);
check_post = lpp_add_cst(si->lpp, buf, lpp_less, si->n_regs - d);
- /* add L\U to check_post */
+ /* add L\U' to check_post */
pset_foreach(live, tmp) {
- if(!set_find_keyval(args, tmp) && !pset_find_ptr(defs, tmp)) {
+ if(!pset_find_ptr(used, tmp) && !pset_find_ptr(defs, tmp)) {
/* if a live value is not used by irn */
tmp_op = get_irn_link(tmp);
lpp_set_factor_fast(si->lpp, check_post, tmp_op->attr.live_range.ilp, 1.0);
}
/***********************************************************
- * I T E R A T I O N O V E R A R G S F O R E P I L O G
+ * I T E R A T I O N O V E R U S E S F O R E P I L O G
**********************************************************/
- set_foreach(args, keyval) {
- ilp_var_t next_lr;
+ pset_foreach(used, tmp) {
+ ilp_var_t prev_lr;
ilp_var_t post_use;
int p = 0;
spill_t *spill;
- ir_node *arg = keyval->key;
+ ir_node *arg = tmp;
op_t *arg_op = get_irn_link(arg);
+ ir_node *remat;
spill = add_to_spill_bb(si, bb, arg);
- /* new live range for each argument */
+ /* new live range for each used value */
ir_snprintf(buf, sizeof(buf), "lr_%N_%N", arg, irn);
- next_lr = lpp_add_var(si->lpp, buf, lpp_binary, 0.0);
-
- i = (int)keyval->val;
+ prev_lr = lpp_add_var(si->lpp, buf, lpp_binary, 0.0);
/* the epilog stuff - including post_use, check_post, check_post_remat */
ir_snprintf(buf, sizeof(buf), "post_use_%N_%N", arg, irn);
if(pset_find_ptr(live, arg)) {
DBG((si->dbg, LEVEL_3, "\t arg %+F is possibly live in epilog of %+F\n", arg, irn));
+ /* post_use >= next_lr + remat */
ir_snprintf(buf, sizeof(buf), "post_use_%N_%N-%d", arg, irn, p++);
cst = lpp_add_cst(si->lpp, buf, lpp_less, 0.0);
lpp_set_factor_fast(si->lpp, cst, post_use, -1.0);
lpp_set_factor_fast(si->lpp, cst, arg_op->attr.live_range.ilp, 1.0);
-#ifdef CHECK_POST_REMAT
- //lpp_set_factor_fast(si->lpp, check_post_remat, arg_op->attr.live_range.ilp, 1.0);
- lpp_set_factor_fast(si->lpp, check_post_remat, post_use, 1.0);
-#endif
}
- /*forall remat2 which use arg add a similar cst*/
- foreach_post_remat(irn, tmp) {
+ /* if value is not an arg of op and not possibly defined by post remat
+ * then it may only die and not become live
+ */
+ if(!set_find_keyval(args, arg)) {
+ /* post_use <= prev_lr */
+ ir_snprintf(buf, sizeof(buf), "req_post_use_%N_%N", arg, irn);
+ cst = lpp_add_cst(si->lpp, buf, lpp_less, 0.0);
+ lpp_set_factor_fast(si->lpp, cst, post_use, 1.0);
+ lpp_set_factor_fast(si->lpp, cst, prev_lr, -1.0);
+
+ if(!pset_find_ptr(remat_defs, arg) && pset_find_ptr(live, arg)) {
+ /* next_lr <= prev_lr */
+ ir_snprintf(buf, sizeof(buf), "next_lr_%N_%N", arg, irn);
+ cst = lpp_add_cst(si->lpp, buf, lpp_less, 0.0);
+ lpp_set_factor_fast(si->lpp, cst, arg_op->attr.live_range.ilp, 1.0);
+ lpp_set_factor_fast(si->lpp, cst, prev_lr, -1.0);
+ }
+ }
+
+
+
+ /* forall post remat which use arg add a similar cst */
+ foreach_post_remat(irn, remat) {
int n;
- for (n=get_irn_arity(tmp)-1; n>=0; --n) {
- ir_node *remat_arg = get_irn_n(tmp, n);
- op_t *remat_op = get_irn_link(tmp);
+ for (n=get_irn_arity(remat)-1; n>=0; --n) {
+ ir_node *remat_arg = get_irn_n(remat, n);
+ op_t *remat_op = get_irn_link(remat);
if(remat_arg == arg) {
DBG((si->dbg, LEVEL_3, "\t found remat with arg %+F in epilog of %+F\n", arg, irn));
}
}
- /* new live range begins for each argument */
- arg_op->attr.live_range.ilp = next_lr;
+ /* new live range begins for each used value */
+ arg_op->attr.live_range.ilp = prev_lr;
arg_op->attr.live_range.op = irn;
+ /*if(!pset_find_ptr(live, arg)) {
+ pset_insert_ptr(live, arg);
+ add_to_spill_bb(si, bb, arg);
+ }*/
pset_insert_ptr(live, arg);
+
}
/* just to be sure */
check_post = ILP_UNDEF;
-#ifdef CHECK_POST_REMAT
- check_post_remat = ILP_UNDEF;
-#endif
}
- /* TODO allow new live ranges even if value does not die after remat??? MAY_DIE_AT_PRE_REMAT */
-
/* requirements for remats */
/* start new live ranges for values used by remats */
foreach_pre_remat(si, irn, tmp) {
if(!has_reg_class(si, remat_arg)) continue;
- /* if value is becoming live through use by remat */
- if(!pset_find_ptr(live, remat_arg)) {
- ir_snprintf(buf, sizeof(buf), "lr_%N_%N", remat_arg, irn);
- prev_lr = lpp_add_var(si->lpp, buf, lpp_binary, 0.0);
-
- arg_op->attr.live_range.ilp = prev_lr;
- arg_op->attr.live_range.op = irn;
-
- DBG((si->dbg, LEVEL_4, " value %+F becoming live through use by remat %+F\n", remat_arg, tmp));
-
- pset_insert_ptr(live, remat_arg);
- add_to_spill_bb(si, bb, remat_arg);
- }
-
/* remat <= live_rang(remat_arg) [ + reload(remat_arg) ] */
ir_snprintf(buf, sizeof(buf), "req_remat_%N_arg_%N", tmp, remat_arg);
cst = lpp_add_cst(si->lpp, buf, lpp_less, 0.0);
assert(!find_post_remat(arg, irn) && "there should be no post remat for an argument of an op");
}
+ del_pset(remat_defs);
+ del_pset(used);
del_set(args);
del_pset(defs);
defs = pset_new_ptr_default();
/* a and b are only interesting if they are in the same phi class */
if(has_reg_class(si, b) && get_phi_class(a) == get_phi_class(b)) {
if(values_interfere_in_block(bb, a, b)) {
- //DBG((si->dbg, LEVEL_1, "\tvalues interfere in %+F: %+F, %+F\n", bb, a, b));
- ir_fprintf(stderr, "\tvalues interfere in %+F: %+F, %+F\n", bb, a, b);
+ DBG((si->dbg, LEVEL_4, "\tvalues interfere in %+F: %+F, %+F\n", bb, a, b));
set_insert_interference(si, si->interferences, a, b, bb);
}
}
cst;
const ir_node *a = interference->a;
const ir_node *b = interference->b;
- struct list_head *pos;
/* any_interf <= \sum interf */
ir_snprintf(buf, sizeof(buf), "interfere_%N_%N", a, b);
#endif
}
+static pset *
+get_spills_for_value(spill_ilp_t * si, ir_node * value)
+{
+ pset *spills = pset_new_ptr_default();
+
+ ir_node *next;
+ defs_t *defs;
+
+ defs = set_find_def(si->values, value);
+
+ if(defs && defs->spills) {
+ for(next = defs->spills; next; next = get_irn_link(next)) {
+ pset_insert_ptr(spills, next);
+ }
+ }
+
+ return spills;
+}
+
+static pset *
+get_remats_for_value(spill_ilp_t * si, ir_node * value)
+{
+ pset *remats = pset_new_ptr_default();
+
+ ir_node *next;
+ defs_t *defs;
+
+ pset_insert_ptr(remats, value);
+ defs = set_find_def(si->values, value);
+
+ if(defs && defs->remats) {
+ for(next = defs->remats; next; next = get_irn_link(next)) {
+ pset_insert_ptr(remats, next);
+ }
+ }
+
+ return remats;
+}
+
+
/**
* @param before The node after which the spill will be placed in the schedule
*/
ir_node **ins;
defs_t *defs;
int n;
+ op_t *op = get_irn_link(phi);
NEW_ARR_A(ir_node*, ins, get_irn_arity(phi));
pset_insert_ptr(si->spills, mem_phi);
#endif
+
return mem_phi;
}
defs->remats = remat;
}
-#if 0
-static void
-collect_spills(spill_ilp_t * si, ir_node * value, pset * spills, pset * visited)
-{
- ir_node *next;
- defs_t *defs;
-
- defs = set_find_def(si->values, value);
-
- if(defs && defs->spills) {
- for(next = defs->spills; next; next = get_irn_link(next)) {
- pset_insert_ptr(spills, next);
- }
- } else if (is_Phi(value)) {
- /* recursion */
- if(!pset_find_ptr(visited, value)) {
- int i,
- n;
-
- pset_insert_ptr(visited, value);
- for(i=0, n=get_irn_arity(value); i<n; ++i) {
- ir_node *arg = get_irn_n(value, i);
-
- collect_spills(si, arg, spills, visited);
- }
- }
- } else {
-// assert(0 && "Phi operand not spilled");
- }
-}
-#endif
-
-static pset *
-get_spills_for_value(spill_ilp_t * si, ir_node * value)
-{
- pset *spills = pset_new_ptr_default();
-// pset *visited = pset_new_ptr_default();
-
-// collect_spills(si, value, spills, visited);
-// del_pset(visited);
- ir_node *next;
- defs_t *defs;
-
- defs = set_find_def(si->values, value);
-
- if(defs && defs->spills) {
- for(next = defs->spills; next; next = get_irn_link(next)) {
- pset_insert_ptr(spills, next);
- }
- }
-
- return spills;
-}
/**
* Add reload before operation and add to list of defs
DBG((si->dbg, LEVEL_3, "\t inserting reload for value %+F before %+F\n", value, after));
defs = set_find_def(si->values, value);
- /* get a spill of this value */
-#if 0
- if((!defs || !defs->spills) && is_Phi(value)) {
- pset *spills;
- spills = get_spills_for_value(si, value);
-
- spill = pset_first(spills);
- del_pset(spills);
-
- if(!defs) {
- defs = set_insert_def(si->values, value);
- }
- defs->spills = spill;
- set_irn_link(spill, NULL);
- } else {
- spill = defs->spills;
- }
-#endif
spill = defs->spills;
assert(spill && "no spill placed before reload");
del_pset(spills_to_do);
}
+static ir_node *
+insert_mem_copy(spill_ilp_t * si, const ir_node * bb, const ir_node * value)
+{
+ ir_node *insert_pos = bb;
+ ir_node *spill;
+ const arch_env_t *arch_env = si->chordal_env->birg->main_env->arch_env;
+
+ /* find last definition of arg value in block */
+ ir_node *next;
+ defs_t *defs;
+ int last = 0;
+
+ defs = set_find_def(si->values, value);
+
+ if(defs && defs->remats) {
+ for(next = defs->remats; next; next = get_irn_link(next)) {
+ if(get_nodes_block(next) == bb && sched_get_time_step(next) > last) {
+ last = sched_get_time_step(next);
+ insert_pos = next;
+ }
+ }
+ }
+
+ if(get_nodes_block(value) == bb && sched_get_time_step(value) > last) {
+ last = sched_get_time_step(value);
+ insert_pos = value;
+ }
+
+ DBG((si->dbg, LEVEL_2, "\t inserting mem copy for value %+F after %+F\n", value, insert_pos));
+
+ spill = be_spill2(arch_env, is_Block(insert_pos)?value:insert_pos, insert_pos, value);
+
+ return spill;
+}
+
static void
phim_fixer(spill_ilp_t *si) {
defs_t *defs;
set_foreach(si->values, defs) {
const ir_node *phi = defs->value;
- ir_node *phi_m = NULL;
- ir_node *next = defs->spills;
- int n;
+ op_t *op = get_irn_link(phi);
+ ir_node *phi_m = NULL;
+ ir_node *next = defs->spills;
+ int n;
if(!is_Phi(phi)) continue;
for(n=get_irn_arity(phi)-1; n>=0; --n) {
const ir_node *value = get_irn_n(phi, n);
defs_t *val_defs = set_find_def(si->values, value);
+ ir_node *arg = get_irn_n(phi_m, n);
/* get a spill of this value */
ir_node *spill = val_defs->spills;
- assert(spill && "no spill placed before PhiM");
+#ifndef NO_MEMCOPIES
+ ir_node *pred = get_Block_cfgpred_block(get_nodes_block(phi), n);
+ lpp_name_t *name = si->lpp->vars[op->attr.live_range.args.copies[n]];
+
+ if(!is_zero(name->value)) {
+ spill = insert_mem_copy(si, pred, value);
+ } else {
+ assert(spill && "no spill placed before PhiM");
+ }
+#else
+ assert(spill && "no spill placed before PhiM");
+#endif
set_irn_n(phi_m, n, spill);
}
}
ir_node *prev = sched_block_last_noncf(si, bb);
op_t *prev_op = get_irn_link(prev);
+ while(be_is_Spill(prev)) {
+ prev = sched_prev(prev);
+ }
+
+ prev_op = get_irn_link(prev);
+
/* insert reload before pre-remats */
- while(!sched_is_end(prev) && !be_is_Reload(prev) && !be_is_Spill(prev)
+ while(!sched_is_end(prev) && !be_is_Reload(prev) && !is_Phi(prev)
&& prev_op->is_remat && prev_op->attr.remat.pre) {
insert_pos = prev;
- prev = sched_prev(insert_pos);
+ do {
+ prev = sched_prev(prev);
+ } while(be_is_Spill(prev));
+
prev_op = get_irn_link(prev);
+
}
reload = insert_reload(si, irn, insert_pos);
if(!is_zero(name->value)) {
ir_node *reload;
ir_node *insert_pos = irn;
- ir_node *prev = insert_pos;
+ ir_node *prev = sched_prev(insert_pos);
op_t *prev_op;
- do {
+ while(be_is_Spill(prev)) {
prev = sched_prev(prev);
- } while(be_is_Spill(prev));
+ }
prev_op = get_irn_link(prev);
be_free_dominance_frontiers(dfi);
}
+
static void
writeback_results(spill_ilp_t * si)
{
delete_unnecessary_remats(si);
si->m_unknown = new_r_Unknown(si->chordal_env->irg, mode_M);
irg_block_walk_graph(si->chordal_env->irg, walker_spill_placer, NULL, si);
- phim_fixer(si);
irg_block_walk_graph(si->chordal_env->irg, walker_reload_placer, NULL, si);
+ phim_fixer(si);
/* clean the remat info! there are still back-edges leading there! */
clean_remat_info(si);
irg_block_walk_graph(si->chordal_env->irg, walker_reload_mover, NULL, si);
}
+
+/**
+ * Walk all irg blocks and check for interfering spills inside of phi classes
+ */
+static void
+luke_meminterferencechecker(ir_node * bb, void * data)
+{
+ spill_ilp_t *si = (spill_ilp_t*)data;
+ irn_live_t *li1,
+ *li2;
+
+ live_foreach(bb, li1) {
+ ir_node *a = (ir_node *) li1->irn;
+
+ if(!be_is_Spill(a) && (!is_Phi(a) || get_irn_mode(a) != mode_T)) continue;
+
+ /* a is only interesting if it is inside a phi class */
+ if (get_phi_class(a)) {
+ for(li2=li1->next; li2; li2 = li2->next) {
+ ir_node *b = (ir_node *) li2->irn;
+
+ if(!be_is_Spill(b) && (!is_Phi(b) || get_irn_mode(b) != mode_T)) continue;
+
+ /* a and b are only interesting if they are in the same phi class */
+ if(get_phi_class(a) == get_phi_class(b)) {
+ if(values_interfere_in_block(bb, a, b)) {
+ ir_fprintf(stderr, "$$ Spills interfere in %+F: %+F, %+F \t$$\n", bb, a, b);
+ }
+ }
+ }
+ }
+ }
+}
+
+static void
+verify_phiclasses(spill_ilp_t * si)
+{
+ /* analyze phi classes */
+ phi_class_compute(si->chordal_env->irg);
+
+ DBG((si->dbg, LEVEL_2, "\t calling memory interference checker\n"));
+ irg_block_walk_graph(si->chordal_env->irg, luke_meminterferencechecker, NULL, si);
+}
+
+static void
+walker_spillslotassigner(ir_node * irn, void * data)
+{
+ spill_ilp_t *si = (spill_ilp_t*)data;
+ void *cls;
+
+ if(!be_is_Spill(irn)) return;
+
+ /* set spill context to phi class if it has one ;) */
+
+ cls = get_phi_class(irn);
+ if(cls)
+ be_set_Spill_context(irn, cls);
+ else
+ be_set_Spill_context(irn, irn);
+}
+
+
+static void
+assign_spillslots(spill_ilp_t * si)
+{
+ DBG((si->dbg, LEVEL_2, "\t calling spill slot assigner\n"));
+ irg_walk_graph(si->chordal_env->irg, walker_spillslotassigner, NULL, si);
+}
+
void
be_spill_remat(const be_chordal_env_t * chordal_env)
{
si.cls = chordal_env->cls;
si.lpp = new_lpp(problem_name, lpp_minimize);
si.remat_info = new_set(cmp_remat_info, 4096);
- si.interferences = new_set(cmp_interference, 4096);
+ si.interferences = new_set(cmp_interference, 32);
si.all_possible_remats = pset_new_ptr_default();
si.spills = pset_new_ptr_default();
si.inverse_ops = pset_new_ptr_default();
// move reloads upwards
be_liveness(chordal_env->irg);
- irg_block_walk_graph(chordal_env->irg, walker_pressure_annotator, NULL, &si);
- move_reloads_upward(&si);
+ //irg_block_walk_graph(chordal_env->irg, walker_pressure_annotator, NULL, &si);
+ //move_reloads_upward(&si);
+
+#ifndef NO_MEMCOPIES
+ verify_phiclasses(&si);
+ assign_spillslots(&si);
+#endif
irg_block_walk_graph(chordal_env->irg, walker_pressure_annotator, NULL, &si);
dump_pressure_graph(&si, dump_suffix2);
- // TODO fix temporarily exceeded regpressure due to remat2s
-
- // TODO insert copys to fix interferences in memory
-
be_analyze_regpressure(chordal_env, "-post");
free_dom(chordal_env->irg);
projects / libfirm / blobdiff