fixed a bunch of warnings
[libfirm] / ir / be / bespill.c
index 57cfbd3..577b56d 100644 (file)
@@ -69,6 +69,7 @@ DEBUG_ONLY(static firm_dbg_module_t *dbg = NULL;)
 typedef struct reloader_t reloader_t;
 struct reloader_t {
        reloader_t *next;
+       ir_node    *can_spill_after;
        ir_node    *reloader;
        ir_node    *rematted_node;
        int         remat_cost_delta; /** costs needed for rematerialization,
@@ -116,6 +117,8 @@ int cmp_spillinfo(const void *x, const void *y, size_t size)
 {
        const spill_info_t *xx = x;
        const spill_info_t *yy = y;
+       (void) size;
+
        return xx->to_spill != yy->to_spill;
 }
 
@@ -207,7 +210,7 @@ void be_add_remat(spill_env_t *env, ir_node *to_spill, ir_node *before,
                to_spill, before));
 }
 
-void be_add_reload(spill_env_t *env, ir_node *to_spill, ir_node *before,
+void be_add_reload2(spill_env_t *env, ir_node *to_spill, ir_node *before, ir_node *can_spill_after,
                    const arch_register_class_t *reload_cls, int allow_remat)
 {
        spill_info_t *info;
@@ -242,15 +245,12 @@ void be_add_reload(spill_env_t *env, ir_node *to_spill, ir_node *before,
        assert(!is_Proj(before) && !be_is_Keep(before));
 
        /* put reload into list */
-       rel                = obstack_alloc(&env->obst, sizeof(rel[0]));
-       rel->next          = info->reloaders;
-       rel->reloader      = before;
-       rel->rematted_node = NULL;
-       if(!allow_remat) {
-               rel->remat_cost_delta = REMAT_COST_INFINITE;
-       } else {
-               rel->remat_cost_delta = 0;
-       }
+       rel                   = obstack_alloc(&env->obst, sizeof(rel[0]));
+       rel->next             = info->reloaders;
+       rel->reloader         = before;
+       rel->rematted_node    = NULL;
+       rel->can_spill_after  = can_spill_after;
+       rel->remat_cost_delta = allow_remat ? 0 : REMAT_COST_INFINITE;
 
        info->reloaders  = rel;
        assert(info->reload_cls == NULL || info->reload_cls == reload_cls);
@@ -260,6 +260,33 @@ void be_add_reload(spill_env_t *env, ir_node *to_spill, ir_node *before,
                to_spill, before, allow_remat ? "" : " not"));
 }
 
+void be_add_reload(spill_env_t *senv, ir_node *to_spill, ir_node *before,
+                   const arch_register_class_t *reload_cls, int allow_remat)
+{
+       be_add_reload2(senv, to_spill, before, to_spill, reload_cls, allow_remat);
+
+}
+
+ir_node *be_get_end_of_block_insertion_point(const ir_node *block)
+{
+       ir_node *last = sched_last(block);
+
+       /* we might have projs and keepanys behind the jump... */
+       while(be_is_Keep(last)) {
+               last = sched_prev(last);
+               assert(!sched_is_end(last));
+       }
+
+       if(!is_cfop(last)) {
+               last = sched_next(last);
+               /* last node must be a cfop, only exception is the start block */
+               assert(last     == get_irg_start_block(get_irn_irg(block)));
+       }
+
+       /* add the reload before the (cond-)jump */
+       return last;
+}
+
 /**
  * Returns the point at which you can insert a node that should be executed
  * before block @p block when coming from pred @p pos.
@@ -267,7 +294,7 @@ void be_add_reload(spill_env_t *env, ir_node *to_spill, ir_node *before,
 static
 ir_node *get_block_insertion_point(ir_node *block, int pos)
 {
-       ir_node *predblock, *last;
+       ir_node *predblock;
 
        /* simply add the reload to the beginning of the block if we only have 1
         * predecessor. We don't need to check for phis as there can't be any in a
@@ -279,22 +306,15 @@ ir_node *get_block_insertion_point(ir_node *block, int pos)
 
        /* We have to reload the value in pred-block */
        predblock = get_Block_cfgpred_block(block, pos);
-       last = sched_last(predblock);
-
-       /* we might have projs and keepanys behind the jump... */
-       while(is_Proj(last) || be_is_Keep(last)) {
-               last = sched_prev(last);
-               assert(!sched_is_end(last));
-       }
-
-       if(!is_cfop(last)) {
-               last = sched_next(last);
-               /* last node must be a cfop, only exception is the start block */
-               assert(last     == get_irg_start_block(get_irn_irg(block)));
-       }
+       return be_get_end_of_block_insertion_point(predblock);
+}
 
-       /* add the reload before the (cond-)jump */
-       return last;
+void be_add_reload_at_end(spill_env_t *env, ir_node *to_spill, const ir_node *block,
+                          const arch_register_class_t *reload_cls,
+                          int allow_remat)
+{
+       ir_node *before = be_get_end_of_block_insertion_point(block);
+       be_add_reload(env, to_spill, before, reload_cls, allow_remat);
 }
 
 void be_add_reload_on_edge(spill_env_t *env, ir_node *to_spill, ir_node *block,
@@ -448,8 +468,9 @@ void spill_phi(spill_env_t *env, spill_info_t *spillinfo)
        /* build a new PhiM */
        ins = alloca(sizeof(ir_node*) * arity);
        for(i = 0; i < arity; ++i) {
-               ins[i] = get_irg_bad(env->irg);
+               ins[i] = new_r_Unknown(env->irg, mode_M);
        }
+       assert(!get_opt_cse());
        spillinfo->spill = new_r_Phi(env->irg, block, arity, ins, mode_M);
 #ifdef FIRM_STATISTICS
        env->spilled_phi_count++;
@@ -527,7 +548,7 @@ void spill_node(spill_env_t *env, spill_info_t *spillinfo)
  * @returns 1 if value is available, 0 otherwise
  */
 static
-int is_value_available(spill_env_t *env, ir_node *arg, ir_node *reloader)
+int is_value_available(spill_env_t *env, const ir_node *arg, const ir_node *reloader)
 {
        if(is_Unknown(arg) || arg == new_NoMem())
                return 1;
@@ -579,7 +600,7 @@ int is_value_available(spill_env_t *env, ir_node *arg, ir_node *reloader)
  * Checks whether the node can principally be rematerialized
  */
 static
-int is_remat_node(spill_env_t *env, ir_node *node)
+int is_remat_node(spill_env_t *env, const ir_node *node)
 {
        const arch_env_t *arch_env = env->arch_env;
 
@@ -602,8 +623,8 @@ int is_remat_node(spill_env_t *env, ir_node *node)
  * >= REMAT_COST_INFINITE if remat is not possible.
  */
 static
-int check_remat_conditions_costs(spill_env_t *env, ir_node *spilled,
-                                 ir_node *reloader, int parentcosts)
+int check_remat_conditions_costs(spill_env_t *env, const ir_node *spilled,
+                                 const ir_node *reloader, int parentcosts)
 {
        int i, arity;
        int argremats;
@@ -620,6 +641,9 @@ int check_remat_conditions_costs(spill_env_t *env, ir_node *spilled,
        if(parentcosts + costs >= env->reload_cost + env->spill_cost) {
                return REMAT_COST_INFINITE;
        }
+       if(arch_irn_is(env->arch_env, spilled, modify_flags)) {
+               return REMAT_COST_INFINITE;
+       }
 
        argremats = 0;
        for(i = 0, arity = get_irn_arity(spilled); i < arity; ++i) {
@@ -687,15 +711,17 @@ ir_node *do_remat(spill_env_t *env, ir_node *spilled, ir_node *reloader)
                          get_irn_arity(spilled), ins);
        copy_node_attr(spilled, res);
        new_backedge_info(res);
-       sched_reset(res);
 
        DBG((dbg, LEVEL_1, "Insert remat %+F of %+F before reloader %+F\n", res, spilled, reloader));
 
-       /* insert in schedule */
-       sched_add_before(reloader, res);
+       if (! is_Proj(res)) {
+               /* insert in schedule */
+               sched_reset(res);
+               sched_add_before(reloader, res);
 #ifdef FIRM_STATISTICS
-       env->remat_count++;
+               env->remat_count++;
 #endif
+       }
 
        return res;
 }
@@ -704,6 +730,7 @@ double be_get_spill_costs(spill_env_t *env, ir_node *to_spill, ir_node *after)
 {
        ir_node *block = get_nodes_block(after);
        double   freq  = get_block_execfreq(env->exec_freq, block);
+       (void) to_spill;
 
        return env->spill_cost * freq;
 }
@@ -723,6 +750,11 @@ double be_get_reload_costs(spill_env_t *env, ir_node *to_spill, ir_node *before)
        return env->reload_cost * freq;
 }
 
+int be_is_rematerializable(spill_env_t *env, const ir_node *to_remat, const ir_node *before)
+{
+       return check_remat_conditions_costs(env, to_remat, before, 0) < REMAT_COST_INFINITE;
+}
+
 double be_get_reload_costs_on_edge(spill_env_t *env, ir_node *to_spill,
                                 ir_node *block, int pos)
 {
@@ -798,7 +830,7 @@ void be_insert_spills_reloads(spill_env_t *env)
 
                                remat_cost_delta      = remat_cost - env->reload_cost;
                                rld->remat_cost_delta = remat_cost_delta;
-                               block                 = get_nodes_block(reloader);
+                               block                 = is_Block(reloader) ? reloader : get_nodes_block(reloader);
                                freq                  = get_block_execfreq(exec_freq, block);
                                all_remat_costs      += remat_cost_delta * freq;
                                DBG((dbg, LEVEL_2, "\tremat costs delta before %+F: "
@@ -880,19 +912,16 @@ void be_insert_spills_reloads(spill_env_t *env)
                si->reloaders = NULL;
        }
 
-#ifdef FIRM_STATISTICS
-       if (be_stat_ev_is_active()) {
-               be_stat_ev("spill_spills", env->spill_count);
-               be_stat_ev("spill_reloads", env->reload_count);
-               be_stat_ev("spill_remats", env->remat_count);
-               be_stat_ev("spill_spilled_phis", env->spilled_phi_count);
-       }
-#endif
+       stat_ev_dbl("spill_spills", env->spill_count);
+       stat_ev_dbl("spill_reloads", env->reload_count);
+       stat_ev_dbl("spill_remats", env->remat_count);
+       stat_ev_dbl("spill_spilled_phis", env->spilled_phi_count);
 
-       be_remove_dead_nodes_from_schedule(env->irg);
        /* Matze: In theory be_ssa_construction should take care of the liveness...
         * try to disable this again in the future */
        be_liveness_invalidate(env->birg->lv);
+
+       be_remove_dead_nodes_from_schedule(env->birg);
 }
 
 void be_init_spill(void)