C99 feature removed.
[libfirm] / ir / be / beprefalloc.c
index 7016c0d..a99d2ac 100644 (file)
@@ -114,7 +114,7 @@ static ir_node **assignments;
  * the information is per firm-node.
  */
 struct allocation_info_t {
-       unsigned  last_uses;      /**< bitset indicating last uses (input pos) */
+       unsigned  last_uses[2];   /**< bitset indicating last uses (input pos) */
        ir_node  *current_value;  /**< copy of the value that should be used */
        ir_node  *original_value; /**< for copies point to original value */
        float     prefs[0];       /**< register preferences */
@@ -287,21 +287,7 @@ static void give_penalties_for_limits(const ir_nodeset_t *live_nodes,
 static void check_defs(const ir_nodeset_t *live_nodes, float weight,
                        ir_node *node)
 {
-       const arch_register_req_t *req;
-
-       if (get_irn_mode(node) == mode_T) {
-               const ir_edge_t *edge;
-               foreach_out_edge(node, edge) {
-                       ir_node *proj = get_edge_src_irn(edge);
-                       check_defs(live_nodes, weight, proj);
-               }
-               return;
-       }
-
-       if (!arch_irn_consider_in_reg_alloc(cls, node))
-               return;
-
-       req = arch_get_register_req_out(node);
+       const arch_register_req_t *req = arch_get_register_req_out(node);
        if (req->type & arch_register_req_type_limited) {
                const unsigned *limited = req->limited;
                float           penalty = weight * DEF_FACTOR;
@@ -361,8 +347,12 @@ static void analyze_block(ir_node *block, void *data)
                if (is_Phi(node))
                        break;
 
-               if (create_preferences)
-                       check_defs(&live_nodes, weight, node);
+               if (create_preferences) {
+                       ir_node *value;
+                       be_foreach_definition(node, cls, value,
+                               check_defs(&live_nodes, weight, value);
+                       );
+               }
 
                /* mark last uses */
                arity = get_irn_arity(node);
@@ -370,9 +360,9 @@ static void analyze_block(ir_node *block, void *data)
                /* the allocation info node currently only uses 1 unsigned value
                   to mark last used inputs. So we will fail for a node with more than
                   32 inputs. */
-               if (arity >= (int) sizeof(unsigned) * 8) {
+               if (arity >= (int) sizeof(info->last_uses) * 8) {
                        panic("Node with more than %d inputs not supported yet",
-                                       (int) sizeof(unsigned) * 8);
+                                       (int) sizeof(info->last_uses) * 8);
                }
 
                info = get_allocation_info(node);
@@ -383,7 +373,7 @@ static void analyze_block(ir_node *block, void *data)
 
                        /* last usage of a value? */
                        if (!ir_nodeset_contains(&live_nodes, op)) {
-                               rbitset_set(&info->last_uses, i);
+                               rbitset_set(info->last_uses, i);
                        }
                }
 
@@ -413,26 +403,13 @@ static void analyze_block(ir_node *block, void *data)
        ir_nodeset_destroy(&live_nodes);
 }
 
-static void congruence_def(ir_nodeset_t *live_nodes, ir_node *node)
+static void congruence_def(ir_nodeset_t *live_nodes, const ir_node *node)
 {
-       const arch_register_req_t *req;
-
-       if (get_irn_mode(node) == mode_T) {
-               const ir_edge_t *edge;
-               foreach_out_edge(node, edge) {
-                       ir_node *def = get_edge_src_irn(edge);
-                       congruence_def(live_nodes, def);
-               }
-               return;
-       }
-
-       if (!arch_irn_consider_in_reg_alloc(cls, node))
-               return;
+       const arch_register_req_t *req = arch_get_register_req_out(node);
 
        /* should be same constraint? */
-       req = arch_get_register_req_out(node);
        if (req->type & arch_register_req_type_should_be_same) {
-               ir_node *insn  = skip_Proj(node);
+               const ir_node *insn  = skip_Proj_const(node);
                int      arity = get_irn_arity(insn);
                int      i;
                unsigned node_idx = get_irn_idx(node);
@@ -485,10 +462,13 @@ static void create_congruence_class(ir_node *block, void *data)
 
        /* check should be same constraints */
        sched_foreach_reverse(block, node) {
+               ir_node *value;
                if (is_Phi(node))
                        break;
 
-               congruence_def(&live_nodes, node);
+               be_foreach_definition(node, cls, value,
+                       congruence_def(&live_nodes, value);
+               );
                be_liveness_transfer(cls, node, &live_nodes);
        }
 
@@ -605,8 +585,6 @@ static void combine_congruence_classes(void)
 
 
 
-
-
 /**
  * Assign register reg to the given node.
  *
@@ -870,6 +848,8 @@ static void assign_reg(const ir_node *block, ir_node *node,
                        break;
        }
        if (i >= n_regs) {
+               /* the common reason to hit this panic is when 1 of your nodes is not
+                * register pressure faithful */
                panic("No register left for %+F\n", node);
        }
 
@@ -1062,7 +1042,7 @@ static void permute_values(ir_nodeset_t *live_nodes, ir_node *before,
 static void free_last_uses(ir_nodeset_t *live_nodes, ir_node *node)
 {
        allocation_info_t     *info      = get_allocation_info(node);
-       const unsigned        *last_uses = &info->last_uses;
+       const unsigned        *last_uses = info->last_uses;
        int                    arity     = get_irn_arity(node);
        int                    i;
 
@@ -1128,7 +1108,7 @@ static void determine_live_through_regs(unsigned *bitset, ir_node *node)
                ir_node               *op;
                const arch_register_t *reg;
 
-               if (!rbitset_is_set(&info->last_uses, i))
+               if (!rbitset_is_set(info->last_uses, i))
                        continue;
 
                op  = get_irn_n(node, i);
@@ -1151,6 +1131,7 @@ static void enforce_constraints(ir_nodeset_t *live_nodes, ir_node *node,
        hungarian_problem_t *bp;
        unsigned l, r;
        unsigned *assignment;
+       ir_node  *value;
 
        /* construct a list of register occupied by live-through values */
        unsigned *live_through_regs = NULL;
@@ -1183,43 +1164,17 @@ static void enforce_constraints(ir_nodeset_t *live_nodes, ir_node *node,
        }
 
        /* is any of the live-throughs using a constrained output register? */
-       if (get_irn_mode(node) == mode_T) {
-               const ir_edge_t *edge;
-
-               foreach_out_edge(node, edge) {
-                       ir_node *proj = get_edge_src_irn(edge);
-                       const arch_register_req_t *req;
-
-                       if (!arch_irn_consider_in_reg_alloc(cls, proj))
-                               continue;
-
-                       req = arch_get_register_req_out(proj);
-                       if (!(req->type & arch_register_req_type_limited))
-                               continue;
-
-                       if (live_through_regs == NULL) {
-                               rbitset_alloca(live_through_regs, n_regs);
-                               determine_live_through_regs(live_through_regs, node);
-                       }
-
-                       rbitset_or(forbidden_regs, req->limited, n_regs);
-                       if (rbitsets_have_common(req->limited, live_through_regs, n_regs)) {
-                               good = false;
-                       }
-               }
-       } else {
-               if (arch_irn_consider_in_reg_alloc(cls, node)) {
-                       const arch_register_req_t *req = arch_get_register_req_out(node);
-                       if (req->type & arch_register_req_type_limited) {
-                               rbitset_alloca(live_through_regs, n_regs);
-                               determine_live_through_regs(live_through_regs, node);
-                               if (rbitsets_have_common(req->limited, live_through_regs, n_regs)) {
-                                       good = false;
-                                       rbitset_or(forbidden_regs, req->limited, n_regs);
-                               }
-                       }
+       be_foreach_definition(node, cls, value,
+               if (! (req_->type & arch_register_req_type_limited))
+                       continue;
+               if (live_through_regs == NULL) {
+                       rbitset_alloca(live_through_regs, n_regs);
+                       determine_live_through_regs(live_through_regs, node);
                }
-       }
+               rbitset_or(forbidden_regs, req_->limited, n_regs);
+               if (rbitsets_have_common(req_->limited, live_through_regs, n_regs))
+                       good = false;
+       );
 
        if (good)
                return;
@@ -1276,7 +1231,7 @@ static void enforce_constraints(ir_nodeset_t *live_nodes, ir_node *node,
                for (r = 0; r < n_regs; ++r) {
                        if (rbitset_is_set(limited, r))
                                continue;
-                       hungarian_remv(bp, r, current_reg);
+                       hungarian_remove(bp, r, current_reg);
                }
        }
 
@@ -1284,7 +1239,7 @@ static void enforce_constraints(ir_nodeset_t *live_nodes, ir_node *node,
        hungarian_prepare_cost_matrix(bp, HUNGARIAN_MODE_MAXIMIZE_UTIL);
 
        assignment = ALLOCAN(unsigned, n_regs);
-       res = hungarian_solve(bp, (int*) assignment, NULL, 0);
+       res = hungarian_solve(bp, assignment, NULL, 0);
        assert(res == 0);
 
 #if 0
@@ -1493,7 +1448,7 @@ static void assign_phi_registers(ir_node *block)
        int                  n_phis = 0;
        int                  n;
        int                  res;
-       int                 *assignment;
+       unsigned            *assignment;
        ir_node             *node;
        hungarian_problem_t *bp;
 
@@ -1547,7 +1502,7 @@ static void assign_phi_registers(ir_node *block)
        //hungarian_print_cost_matrix(bp, 7);
        hungarian_prepare_cost_matrix(bp, HUNGARIAN_MODE_MAXIMIZE_UTIL);
 
-       assignment = ALLOCAN(int, n_regs);
+       assignment = ALLOCAN(unsigned, n_regs);
        res        = hungarian_solve(bp, assignment, NULL, 0);
        assert(res == 0);
 
@@ -1562,7 +1517,7 @@ static void assign_phi_registers(ir_node *block)
                if (!arch_irn_consider_in_reg_alloc(cls, node))
                        continue;
 
-               r   = assignment[n++];
+               r = assignment[n++];
                assert(rbitset_is_set(normal_regs, r));
                reg = arch_register_for_index(cls, r);
                DB((dbg, LEVEL_2, "Assign %+F -> %s\n", node, reg->name));
@@ -1705,6 +1660,7 @@ static void allocate_coalesce_block(ir_node *block, void *data)
        sched_foreach(block, node) {
                int i;
                int arity;
+               ir_node *value;
 
                /* phis are already assigned */
                if (is_Phi(node))
@@ -1735,17 +1691,9 @@ static void allocate_coalesce_block(ir_node *block, void *data)
 
                /* assign output registers */
                /* TODO: 2 phases: first: pre-assigned ones, 2nd real regs */
-               if (get_irn_mode(node) == mode_T) {
-                       const ir_edge_t *edge;
-                       foreach_out_edge(node, edge) {
-                               ir_node *proj = get_edge_src_irn(edge);
-                               if (!arch_irn_consider_in_reg_alloc(cls, proj))
-                                       continue;
-                               assign_reg(block, proj, forbidden_regs);
-                       }
-               } else if (arch_irn_consider_in_reg_alloc(cls, node)) {
-                       assign_reg(block, node, forbidden_regs);
-               }
+               be_foreach_definition(node, cls, value,
+                       assign_reg(block, value, forbidden_regs);
+               );
        }
 
        ir_nodeset_destroy(&live_nodes);
@@ -1983,10 +1931,10 @@ static void be_pref_alloc(ir_graph *new_irg)
 
                /* verify schedule and register pressure */
                be_timer_push(T_VERIFY);
-               if (be_get_irg_options(irg)->vrfy_option == BE_VRFY_WARN) {
+               if (be_get_irg_options(irg)->verify_option == BE_VERIFY_WARN) {
                        be_verify_schedule(irg);
                        be_verify_register_pressure(irg, cls);
-               } else if (be_get_irg_options(irg)->vrfy_option == BE_VRFY_ASSERT) {
+               } else if (be_get_irg_options(irg)->verify_option == BE_VERIFY_ASSERT) {
                        assert(be_verify_schedule(irg) && "Schedule verification failed");
                        assert(be_verify_register_pressure(irg, cls)
                                && "Register pressure verification failed");
@@ -2011,9 +1959,9 @@ static void be_pref_alloc(ir_graph *new_irg)
        be_timer_pop(T_RA_SPILL_APPLY);
 
        be_timer_push(T_VERIFY);
-       if (be_get_irg_options(irg)->vrfy_option == BE_VRFY_WARN) {
+       if (be_get_irg_options(irg)->verify_option == BE_VERIFY_WARN) {
                be_verify_register_allocation(irg);
-       } else if (be_get_irg_options(irg)->vrfy_option == BE_VRFY_ASSERT) {
+       } else if (be_get_irg_options(irg)->verify_option == BE_VERIFY_ASSERT) {
                assert(be_verify_register_allocation(irg)
                       && "Register allocation invalid");
        }