fix cparser warnings in beprefalloc
[libfirm] / ir / be / beprefalloc.c
index 834d93b..164262d 100644 (file)
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 1995-2008 University of Karlsruhe.  All right reserved.
+ * Copyright (C) 1995-2011 University of Karlsruhe.  All right reserved.
  *
  * This file is part of libFirm.
  *
@@ -87,14 +87,13 @@ DEBUG_ONLY(static firm_dbg_module_t *dbg = NULL;)
 static struct obstack               obst;
 static ir_graph                    *irg;
 static const arch_register_class_t *cls;
-static const arch_register_req_t   *default_cls_req;
 static be_lv_t                     *lv;
 static const ir_exec_freq          *execfreqs;
 static unsigned                     n_regs;
 static unsigned                    *normal_regs;
 static int                         *congruence_classes;
 static ir_node                    **block_order;
-static int                          n_block_order;
+static size_t                       n_block_order;
 static int                          create_preferences        = true;
 static int                          create_congruence_classes = true;
 static int                          propagate_phi_registers   = true;
@@ -142,7 +141,7 @@ typedef struct block_info_t block_info_t;
  */
 static allocation_info_t *get_allocation_info(ir_node *node)
 {
-       allocation_info_t *info = get_irn_link(node);
+       allocation_info_t *info = (allocation_info_t*)get_irn_link(node);
        if (info == NULL) {
                info = OALLOCFZ(&obst, allocation_info_t, prefs, n_regs);
                info->current_value  = node;
@@ -163,7 +162,7 @@ static allocation_info_t *try_get_allocation_info(const ir_node *node)
  */
 static block_info_t *get_block_info(ir_node *block)
 {
-       block_info_t *info = get_irn_link(block);
+       block_info_t *info = (block_info_t*)get_irn_link(block);
 
        assert(is_Block(block));
        if (info == NULL) {
@@ -174,24 +173,6 @@ static block_info_t *get_block_info(ir_node *block)
        return info;
 }
 
-/**
- * Get default register requirement for the current register class
- */
-static const arch_register_req_t *get_default_req_current_cls(void)
-{
-       if (default_cls_req == NULL) {
-               struct obstack      *obst = get_irg_obstack(irg);
-               arch_register_req_t *req  = OALLOCZ(obst, arch_register_req_t);
-
-               req->type  = arch_register_req_type_normal;
-               req->cls   = cls;
-               req->width = 1;
-
-               default_cls_req = req;
-       }
-       return default_cls_req;
-}
-
 /**
  * Link the allocation info of a node to a copy.
  * Afterwards, both nodes uses the same allocation info.
@@ -237,7 +218,7 @@ static void give_penalties_for_limits(const ir_nodeset_t *live_nodes,
 {
        ir_nodeset_iterator_t iter;
        unsigned              r;
-       unsigned              n_allowed;
+       size_t                n_allowed;
        allocation_info_t     *info = get_allocation_info(node);
        ir_node               *neighbor;
 
@@ -654,12 +635,12 @@ static bool try_optimistic_split(ir_node *to_split, ir_node *before,
        ir_node               *original_insn;
        ir_node               *block;
        ir_node               *copy;
-       unsigned               r;
+       unsigned               r = 0;
        unsigned               from_r;
        unsigned               i;
        allocation_info_t     *info = get_allocation_info(to_split);
        reg_pref_t            *prefs;
-       float                  delta;
+       float                  delta = 0;
        float                  split_threshold;
 
        (void) pref;
@@ -759,21 +740,21 @@ static bool try_optimistic_split(ir_node *to_split, ir_node *before,
 static void assign_reg(const ir_node *block, ir_node *node,
                        unsigned *forbidden_regs)
 {
-       const arch_register_t     *reg;
+       const arch_register_t     *final_reg;
        allocation_info_t         *info;
        const arch_register_req_t *req;
        reg_pref_t                *reg_prefs;
        ir_node                   *in_node;
-       unsigned                   i;
-       const unsigned            *allowed_regs;
        unsigned                   r;
+       const unsigned            *allowed_regs;
+       unsigned                   final_reg_index = 0;
 
        assert(!is_Phi(node));
        /* preassigned register? */
-       reg = arch_get_irn_register(node);
-       if (reg != NULL) {
-               DB((dbg, LEVEL_2, "Preassignment %+F -> %s\n", node, reg->name));
-               use_reg(node, reg);
+       final_reg = arch_get_irn_register(node);
+       if (final_reg != NULL) {
+               DB((dbg, LEVEL_2, "Preassignment %+F -> %s\n", node, final_reg->name));
+               use_reg(node, final_reg);
                return;
        }
 
@@ -793,37 +774,36 @@ static void assign_reg(const ir_node *block, ir_node *node,
                for (i = 0; i < arity; ++i) {
                        ir_node               *in;
                        const arch_register_t *reg;
-                       unsigned               r;
+                       unsigned               reg_index;
                        if (!rbitset_is_set(&req->other_same, i))
                                continue;
 
                        in  = get_irn_n(in_node, i);
                        reg = arch_get_irn_register(in);
                        assert(reg != NULL);
-                       r = arch_register_get_index(reg);
+                       reg_index = arch_register_get_index(reg);
 
                        /* if the value didn't die here then we should not propagate the
                         * should_be_same info */
-                       if (assignments[r] == in)
+                       if (assignments[reg_index] == in)
                                continue;
 
-                       info->prefs[r] += weight * AFF_SHOULD_BE_SAME;
+                       info->prefs[reg_index] += weight * AFF_SHOULD_BE_SAME;
                }
        }
 
        /* create list of register candidates and sort by their preference */
        DB((dbg, LEVEL_2, "Candidates for %+F:", node));
-       reg_prefs = alloca(n_regs * sizeof(reg_prefs[0]));
+       reg_prefs = ALLOCAN(reg_pref_t, n_regs);
        fill_sort_candidates(reg_prefs, info);
-       for (i = 0; i < n_regs; ++i) {
-               unsigned num = reg_prefs[i].num;
+       for (r = 0; r < n_regs; ++r) {
+               unsigned num = reg_prefs[r].num;
                const arch_register_t *reg;
 
                if (!rbitset_is_set(normal_regs, num))
                        continue;
-
                reg = arch_register_for_index(cls, num);
-               DB((dbg, LEVEL_2, " %s(%f)", reg->name, reg_prefs[i].pref));
+               DB((dbg, LEVEL_2, " %s(%f)", reg->name, reg_prefs[r].pref));
        }
        DB((dbg, LEVEL_2, "\n"));
 
@@ -832,33 +812,38 @@ static void assign_reg(const ir_node *block, ir_node *node,
                allowed_regs = req->limited;
        }
 
-       for (i = 0; i < n_regs; ++i) {
+       for (r = 0; r < n_regs; ++r) {
                float   pref, delta;
                ir_node *before;
                bool    res;
 
-               r = reg_prefs[i].num;
-               if (!rbitset_is_set(allowed_regs, r))
+               final_reg_index = reg_prefs[r].num;
+               if (!rbitset_is_set(allowed_regs, final_reg_index))
                        continue;
-               if (assignments[r] == NULL)
+               /* alignment constraint? */
+               if (req->width > 1 && (req->type & arch_register_req_type_aligned)
+                               && (final_reg_index % req->width) != 0)
+                       continue;
+
+               if (assignments[final_reg_index] == NULL)
                        break;
-               pref   = reg_prefs[i].pref;
-               delta  = i+1 < n_regs ? pref - reg_prefs[i+1].pref : 0;
+               pref   = reg_prefs[r].pref;
+               delta  = r+1 < n_regs ? pref - reg_prefs[r+1].pref : 0;
                before = skip_Proj(node);
-               res    = try_optimistic_split(assignments[r], before,
+               res    = try_optimistic_split(assignments[final_reg_index], before,
                                              pref, delta, forbidden_regs, 0);
                if (res)
                        break;
        }
-       if (i >= n_regs) {
+       if (r >= n_regs) {
                /* the common reason to hit this panic is when 1 of your nodes is not
                 * register pressure faithful */
                panic("No register left for %+F\n", node);
        }
 
-       reg = arch_register_for_index(cls, r);
-       DB((dbg, LEVEL_2, "Assign %+F -> %s\n", node, reg->name));
-       use_reg(node, reg);
+       final_reg = arch_register_for_index(cls, final_reg_index);
+       DB((dbg, LEVEL_2, "Assign %+F -> %s\n", node, final_reg->name));
+       use_reg(node, final_reg);
 }
 
 /**
@@ -878,7 +863,7 @@ static void assign_reg(const ir_node *block, ir_node *node,
  * First we count how many destinations a single value has. At the same time
  * we can be sure that each destination register has at most 1 source register
  * (it can have 0 which means we don't care what value is in it).
- * We ignore all fullfilled permuations (like 7->7)
+ * We ignore all fulfilled permuations (like 7->7)
  * In a first pass we create as much copy instructions as possible as they
  * are generally cheaper than exchanges. We do this by counting into how many
  * destinations a register has to be copied (in the example it's 2 for register
@@ -886,8 +871,8 @@ static void assign_reg(const ir_node *block, ir_node *node,
  * We can then create a copy into every destination register when the usecount
  * of that register is 0 (= noone else needs the value in the register).
  *
- * After this step we should have cycles left. We implement a cyclic permutation
- * of n registers with n-1 transpositions.
+ * After this step we should only have cycles left. We implement a cyclic
+ * permutation of n registers with n-1 transpositions.
  *
  * @param live_nodes   the set of live nodes, updated due to live range split
  * @param before       the node before we add the permutation
@@ -1146,7 +1131,7 @@ static void enforce_constraints(ir_nodeset_t *live_nodes, ir_node *node,
                const arch_register_t     *reg;
                const arch_register_req_t *req;
                const unsigned            *limited;
-               unsigned                  r;
+               unsigned                   reg_index;
 
                if (!arch_irn_consider_in_reg_alloc(cls, op))
                        continue;
@@ -1156,10 +1141,10 @@ static void enforce_constraints(ir_nodeset_t *live_nodes, ir_node *node,
                if (!(req->type & arch_register_req_type_limited))
                        continue;
 
-               limited = req->limited;
-               reg     = arch_get_irn_register(op);
-               r       = arch_register_get_index(reg);
-               if (!rbitset_is_set(limited, r)) {
+               limited   = req->limited;
+               reg       = arch_get_irn_register(op);
+               reg_index = arch_register_get_index(reg);
+               if (!rbitset_is_set(limited, reg_index)) {
                        /* found an assignment outside the limited set */
                        good = false;
                        break;
@@ -1258,7 +1243,7 @@ static void enforce_constraints(ir_nodeset_t *live_nodes, ir_node *node,
        permute_values(live_nodes, node, assignment);
 }
 
-/** test wether a node @p n is a copy of the value of node @p of */
+/** test whether a node @p n is a copy of the value of node @p of */
 static bool is_copy_of(ir_node *value, ir_node *test_value)
 {
        allocation_info_t *test_info;
@@ -1280,9 +1265,9 @@ static bool is_copy_of(ir_node *value, ir_node *test_value)
 static int find_value_in_block_info(block_info_t *info, ir_node *value)
 {
        unsigned   r;
-       ir_node  **assignments = info->assignments;
+       ir_node  **end_assignments = info->assignments;
        for (r = 0; r < n_regs; ++r) {
-               ir_node *a_value = assignments[r];
+               ir_node *a_value = end_assignments[r];
 
                if (a_value == NULL)
                        continue;
@@ -1618,19 +1603,15 @@ static void allocate_coalesce_block(ir_node *block, void *data)
                }
 
                if (need_phi) {
-                       ir_mode                   *mode = get_irn_mode(node);
-                       const arch_register_req_t *req  = get_default_req_current_cls();
-                       ir_node                   *phi;
-
-                       phi = new_r_Phi(block, n_preds, phi_ins, mode);
-                       be_set_phi_reg_req(phi, req);
+                       ir_mode *mode = get_irn_mode(node);
+                       ir_node *phi  = be_new_Phi(block, n_preds, phi_ins, mode, cls);
 
                        DB((dbg, LEVEL_3, "Create Phi %+F (for %+F) -", phi, node));
 #ifdef DEBUG_libfirm
                        {
-                               int i;
-                               for (i = 0; i < n_preds; ++i) {
-                                       DB((dbg, LEVEL_3, " %+F", phi_ins[i]));
+                               int pi;
+                               for (pi = 0; pi < n_preds; ++pi) {
+                                       DB((dbg, LEVEL_3, " %+F", phi_ins[pi]));
                                }
                                DB((dbg, LEVEL_3, "\n"));
                        }
@@ -1677,7 +1658,6 @@ static void allocate_coalesce_block(ir_node *block, void *data)
 
        /* assign instructions in the block */
        sched_foreach(block, node) {
-               int i;
                int arity;
                ir_node *value;
 
@@ -1750,43 +1730,43 @@ struct block_costs_t {
 
 static int cmp_block_costs(const void *d1, const void *d2)
 {
-       const ir_node       * const *block1 = d1;
-       const ir_node       * const *block2 = d2;
-       const block_costs_t *info1  = get_irn_link(*block1);
-       const block_costs_t *info2  = get_irn_link(*block2);
+       const ir_node       * const *block1 = (const ir_node**)d1;
+       const ir_node       * const *block2 = (const ir_node**)d2;
+       const block_costs_t *info1  = (const block_costs_t*)get_irn_link(*block1);
+       const block_costs_t *info2  = (const block_costs_t*)get_irn_link(*block2);
        return QSORT_CMP(info2->costs, info1->costs);
 }
 
 static void determine_block_order(void)
 {
-       int i;
+       size_t    p;
        ir_node **blocklist = be_get_cfgpostorder(irg);
-       int       n_blocks  = ARR_LEN(blocklist);
+       size_t    n_blocks  = ARR_LEN(blocklist);
        int       dfs_num   = 0;
        pdeq     *worklist  = new_pdeq();
        ir_node **order     = XMALLOCN(ir_node*, n_blocks);
-       int       order_p   = 0;
+       size_t    order_p   = 0;
 
        /* clear block links... */
-       for (i = 0; i < n_blocks; ++i) {
-               ir_node *block = blocklist[i];
+       for (p = 0; p < n_blocks; ++p) {
+               ir_node *block = blocklist[p];
                set_irn_link(block, NULL);
        }
 
        /* walk blocks in reverse postorder, the costs for each block are the
         * sum of the costs of its predecessors (excluding the costs on backedges
         * which we can't determine) */
-       for (i = n_blocks-1; i >= 0; --i) {
+       for (p = n_blocks; p > 0;) {
                block_costs_t *cost_info;
-               ir_node *block = blocklist[i];
+               ir_node *block = blocklist[--p];
 
                float execfreq   = (float)get_block_execfreq(execfreqs, block);
                float costs      = execfreq;
                int   n_cfgpreds = get_Block_n_cfgpreds(block);
-               int   p;
-               for (p = 0; p < n_cfgpreds; ++p) {
-                       ir_node       *pred_block = get_Block_cfgpred_block(block, p);
-                       block_costs_t *pred_costs = get_irn_link(pred_block);
+               int   p2;
+               for (p2 = 0; p2 < n_cfgpreds; ++p2) {
+                       ir_node       *pred_block = get_Block_cfgpred_block(block, p2);
+                       block_costs_t *pred_costs = (block_costs_t*)get_irn_link(pred_block);
                        /* we don't have any info for backedges */
                        if (pred_costs == NULL)
                                continue;
@@ -1805,15 +1785,15 @@ static void determine_block_order(void)
        ir_reserve_resources(irg, IR_RESOURCE_BLOCK_VISITED);
        inc_irg_block_visited(irg);
 
-       for (i = 0; i < n_blocks; ++i) {
-               ir_node       *block = blocklist[i];
+       for (p = 0; p < n_blocks; ++p) {
+               ir_node       *block = blocklist[p];
                if (Block_block_visited(block))
                        continue;
 
                /* continually add predecessors with highest costs to worklist
                 * (without using backedges) */
                do {
-                       block_costs_t *info       = get_irn_link(block);
+                       block_costs_t *info       = (block_costs_t*)get_irn_link(block);
                        ir_node       *best_pred  = NULL;
                        float          best_costs = -1;
                        int            n_cfgpred  = get_Block_n_cfgpreds(block);
@@ -1823,7 +1803,7 @@ static void determine_block_order(void)
                        mark_Block_block_visited(block);
                        for (i = 0; i < n_cfgpred; ++i) {
                                ir_node       *pred_block = get_Block_cfgpred_block(block, i);
-                               block_costs_t *pred_info  = get_irn_link(pred_block);
+                               block_costs_t *pred_info  = (block_costs_t*)get_irn_link(pred_block);
 
                                /* ignore backedges */
                                if (pred_info->dfs_num > info->dfs_num)
@@ -1839,7 +1819,7 @@ static void determine_block_order(void)
 
                /* now put all nodes in the worklist in our final order */
                while (!pdeq_empty(worklist)) {
-                       ir_node *pblock = pdeq_getr(worklist);
+                       ir_node *pblock = (ir_node*)pdeq_getr(worklist);
                        assert(order_p < n_blocks);
                        order[order_p++] = pblock;
                }
@@ -1863,7 +1843,7 @@ static void determine_block_order(void)
  */
 static void be_pref_alloc_cls(void)
 {
-       int i;
+       size_t i;
 
        lv = be_assure_liveness(irg);
        be_liveness_assure_sets(lv);
@@ -1922,7 +1902,7 @@ static void spill(void)
 static void be_pref_alloc(ir_graph *new_irg)
 {
        const arch_env_t *arch_env = be_get_irg_arch_env(new_irg);
-       int   n_cls                = arch_env_get_n_reg_class(arch_env);
+       int   n_cls                = arch_env->n_register_classes;
        int   c;
 
        obstack_init(&obst);
@@ -1934,8 +1914,7 @@ static void be_pref_alloc(ir_graph *new_irg)
        determine_block_order();
 
        for (c = 0; c < n_cls; ++c) {
-               cls             = arch_env_get_reg_class(arch_env, c);
-               default_cls_req = NULL;
+               cls = &arch_env->register_classes[c];
                if (arch_register_class_flags(cls) & arch_register_class_flag_manual_ra)
                        continue;
 
@@ -1943,7 +1922,7 @@ static void be_pref_alloc(ir_graph *new_irg)
 
                n_regs      = arch_register_class_n_regs(cls);
                normal_regs = rbitset_malloc(n_regs);
-               be_abi_set_non_ignore_regs(be_get_irg_abi(irg), cls, normal_regs);
+               be_set_allocatable_regs(irg, cls, normal_regs);
 
                spill();
 
@@ -1988,7 +1967,7 @@ static void be_pref_alloc(ir_graph *new_irg)
        obstack_free(&obst, NULL);
 }
 
-BE_REGISTER_MODULE_CONSTRUCTOR(be_init_pref_alloc);
+BE_REGISTER_MODULE_CONSTRUCTOR(be_init_pref_alloc)
 void be_init_pref_alloc(void)
 {
        static be_ra_t be_ra_pref = {