* Heuristic for minimizing copies using a queue which holds 'qnodes' not yet
* examined. A qnode has a 'target color', nodes out of the opt unit and
* a 'conflict graph'. 'Conflict graph' = "Interference graph' + 'conflict edges'
- * A 'max indep set' is determined form these. We try to color this mis using a
+ * A 'max indep set' is determined from these. We try to color this mis using a
* color-exchanging mechanism. Occuring conflicts are modeled with 'conflict edges'
* and the qnode is reinserted in the queue. The first qnode colored without
* conflicts is the best one.
*/
typedef struct _qnode_t {
struct list_head queue; /**< chaining of unit_t->queue */
- const unit_t *ou; /**< the opt unit this qnode belongs to */
+ const unit_t *ou; /**< the opt unit this node belongs to */
int color; /**< target color */
set *conflicts; /**< contains conflict_t's. All internal conflicts */
int mis_costs; /**< costs of nodes/copies in the mis. */
const conflict_t *yy = y;
(void) size;
- return ! (xx->n1 == yy->n1 && xx->n2 == yy->n2);
+ return xx->n1 != yy->n1 || xx->n2 != yy->n2;
}
/**
conflict_t c;
DBG((dbg, LEVEL_4, "\t %+F -- %+F\n", n1, n2));
- if ((int)n1 < (int)n2) {
+ if (get_irn_node_nr(n1) < get_irn_node_nr(n2)) {
c.n1 = n1;
c.n2 = n2;
} else {
if (n1!=n2 && nodes_interfere(qn->ou->co->cenv, n1, n2))
return 1;
/* search for recoloring conflicts */
- if ((int)n1 < (int)n2) {
+ if (get_irn_node_nr(n1) < get_irn_node_nr(n2)) {
c.n1 = n1;
c.n2 = n2;
} else {
c.n1 = n2;
c.n2 = n1;
}
- return (int) set_find(qn->conflicts, &c, sizeof(c), HASH_CONFLICT(c));
+ return set_find(qn->conflicts, &c, sizeof(c), HASH_CONFLICT(c)) != 0;
}
static int set_cmp_node_stat_t(const void *x, const void *y, size_t size) {
(void) size;
- return ((node_stat_t *)x)->irn != ((node_stat_t *)y)->irn;
+ return ((const node_stat_t*)x)->irn != ((const node_stat_t*)y)->irn;
}
/**
* Finds a node status entry of a node if existent. Otherwise return NULL
*/
-static INLINE node_stat_t *qnode_find_node(const qnode_t *qn, ir_node *irn) {
+static INLINE const node_stat_t *qnode_find_node(const qnode_t *qn, ir_node *irn) {
node_stat_t find;
find.irn = irn;
return set_find(qn->changed_nodes, &find, sizeof(find), nodeset_hash(irn));
* Returns the virtual color of a node if set before, else returns the real color.
*/
static INLINE int qnode_get_new_color(const qnode_t *qn, ir_node *irn) {
- node_stat_t *found = qnode_find_node(qn, irn);
+ const node_stat_t *found = qnode_find_node(qn, irn);
if (found)
return found->new_color;
else
* processed node.
*/
static INLINE int qnode_is_pinned_local(const qnode_t *qn, ir_node *irn) {
- node_stat_t *found = qnode_find_node(qn, irn);
+ const node_stat_t *found = qnode_find_node(qn, irn);
if (found)
return found->pinned_local;
else
*/
#define CHANGE_SAVE NULL
#define CHANGE_IMPOSSIBLE (ir_node *)1
-#define is_conflicting_node(n) (((int)n) > 1)
/**
* Performs virtual re-coloring of node @p n to color @p col. Virtual colors of
} else if (confl_node == CHANGE_IMPOSSIBLE) {
DBG((dbg, LEVEL_3, "\t Impossible --> remove from qnode\n"));
qnode_add_conflict(qn, test_node, test_node);
+ return 0;
} else {
if (qnode_is_pinned_local(qn, confl_node)) {
/* changing test_node would change back a node of current ou */
DBG((dbg, LEVEL_3, "\t Conflicting global --> remove from qnode\n"));
qnode_add_conflict(qn, test_node, test_node);
}
- }
-
- if (confl_node != CHANGE_SAVE)
return 0;
+ }
}
return 1;
}
ou_insert_qnode(ou, new_qnode(ou, idx));
/* search best */
- while (!list_empty(&ou->queue)) {
+ for (;;) {
+ assert(!list_empty(&ou->queue));
/* get head of queue */
curr = list_entry_queue(ou->queue.next);
list_del(&curr->queue);