moved verification flags from irvrfy to irflag

[libfirm] / ir / ana / cgana.c

diff --git a/ir/ana/cgana.c b/ir/ana/cgana.c
index 2259ecb..b4b0512 100644 (file)
--- a/ir/ana/cgana.c
+++ b/ir/ana/cgana.c
@@ -54,8 +54,7 @@
 
 
 
-/* Eindeutige Adresse zur Markierung von besuchten Knoten und zur
- * Darstellung der unbekannten Methode. */
+/* unambiguous address used as a mark. */
 static void *MARK = &MARK;
 
 static eset *entities = NULL;
@@ -82,7 +81,7 @@ static entity *get_inherited_methods_implementation(entity *inh_meth) {
 }
 
 /** Collect the entity representing the implementation of this
- *  entity (not the same if inherited) and all entities for overwriting
+ *  method (not the same if inherited) and all entities for overwriting
  *  implementations in "set".
  *  If the implementation of the method is not included in the
  *  compilation unit "open" is set to true.
@@ -94,7 +93,7 @@ static entity *get_inherited_methods_implementation(entity *inh_meth) {
  * @param size     Number of entities in set.
  * @param open
  */
-static void collect_impls(entity *method, eset *set, int *size, bool *open) {
+static void collect_impls(entity *method, eset *set, int *size, int *open) {
   int i;
   entity *impl;
 
@@ -128,7 +127,7 @@ static entity ** get_impl_methods(entity * method) {
   eset * set = eset_create();
   int size = 0;
   entity ** arr;
-  bool open = false;
+  int open = 0;
 
   /* Collect all method entities that can be called here */
   collect_impls(method, set, &size, &open);
@@ -472,6 +471,14 @@ static void free_ana_walker(ir_node *node, void *env) {
 
 /**
  * Add all method addresses in global initializers to the set.
+ *
+ * @note
+ * We do NOT check the type here, just it it's an entity address.
+ * The reason for this is code like:
+ *
+ * void *p = function;
+ *
+ * which is sometimes used to anchor functions.
  */
 static void add_method_address(entity *ent, eset *set)
 {
@@ -486,10 +493,8 @@ static void add_method_address(entity *ent, eset *set)
   if (is_atomic_entity(ent)) {
     tp = get_entity_type(ent);
 
-    /* only function pointers are interesting */
-    if (! is_Pointer_type(tp))
-      return;
-    if (! is_Method_type(get_pointer_points_to_type(tp)))
+    /* ignore methods: these of course reference it's address */
+    if (is_Method_type(tp))
       return;
 
     /* let's check if it's the address of a function */
@@ -498,7 +503,8 @@ static void add_method_address(entity *ent, eset *set)
       if (get_SymConst_kind(n) == symconst_addr_ent) {
         ent = get_SymConst_entity(n);
 
-        eset_insert(set, ent);
+        if (is_Method_type(get_entity_type(ent)))
+          eset_insert(set, ent);
       }
     }
   }
@@ -511,7 +517,8 @@ static void add_method_address(entity *ent, eset *set)
         if (get_SymConst_kind(n) == symconst_addr_ent) {
           entity *ent = get_SymConst_entity(n);
 
-          eset_insert(set, ent);
+          if (is_Method_type(get_entity_type(ent)))
+            eset_insert(set, ent);
         }
       }
     }