rename to avoid name clashes with libfirm changes
[cparser] / ast2firm.c
index 1b9cf5c..a908ab7 100644 (file)
@@ -430,22 +430,23 @@ static ir_type *create_array_type(array_type_t *type)
        dbg_info *dbgi   = get_dbg_info(&type->type.source_position);
        ir_type *ir_type = new_d_type_array(id, 1, ir_element_type, dbgi);
 
+       const int align = get_type_alignment_bytes(ir_element_type);
+       set_type_alignment_bytes(ir_type, align);
+
        if(type->size != NULL) {
                int n_elements = fold_constant(type->size);
 
                set_array_bounds_int(ir_type, 0, 0, n_elements);
 
                size_t elemsize = get_type_size_bytes(ir_element_type);
-               int align = get_type_alignment_bytes(ir_element_type);
                if(elemsize % align > 0) {
                        elemsize += align - (elemsize % align);
                }
                set_type_size_bytes(ir_type, n_elements * elemsize);
-               set_type_alignment_bytes(ir_type, align);
-               set_type_state(ir_type, layout_fixed);
        } else {
                set_array_lower_bound_int(ir_type, 0, 0);
        }
+       set_type_state(ir_type, layout_fixed);
 
        return ir_type;
 }
@@ -539,34 +540,65 @@ static ir_type *create_bitfield_type(bitfield_type_t *const type)
 
 #define INVALID_TYPE ((ir_type_ptr)-1)
 
-static ir_type *create_struct_type(compound_type_t *type)
+static ir_type *create_union_type(compound_type_t *type, ir_type *irtype,
+                                  size_t *outer_offset, size_t *outer_align);
+
+static ir_type *create_struct_type(compound_type_t *type, ir_type *irtype,
+                                   size_t *outer_offset, size_t *outer_align)
 {
        declaration_t *declaration = type->declaration;
        if(declaration->v.irtype != NULL) {
                return declaration->v.irtype;
        }
 
-       symbol_t *symbol = declaration->symbol;
-       ident    *id;
-       if(symbol != NULL) {
-               id = unique_ident(symbol->string);
-       } else {
-               id = unique_ident("__anonymous_struct");
-       }
-       dbg_info *dbgi  = get_dbg_info(&type->type.source_position);
-       ir_type *irtype = new_d_type_struct(id, dbgi);
-
-       type->type.firm_type = irtype;
-
        size_t align_all  = 1;
        size_t offset     = 0;
        size_t bit_offset = 0;
+       if(irtype == NULL) {
+               symbol_t *symbol = declaration->symbol;
+               ident    *id;
+               if(symbol != NULL) {
+                       id = unique_ident(symbol->string);
+               } else {
+                       id = unique_ident("__anonymous_struct");
+               }
+               dbg_info *dbgi  = get_dbg_info(&type->type.source_position);
+
+               irtype = new_d_type_struct(id, dbgi);
+
+               declaration->v.irtype = irtype;
+               type->type.firm_type  = irtype;
+       } else {
+               offset    = *outer_offset;
+               align_all = *outer_align;
+       }
+
        declaration_t *entry = declaration->scope.declarations;
        for( ; entry != NULL; entry = entry->next) {
                if(entry->namespc != NAMESPACE_NORMAL)
                        continue;
 
-               type_t  *entry_type  = skip_typeref(entry->type);
+               symbol_t *symbol     = entry->symbol;
+               type_t   *entry_type = skip_typeref(entry->type);
+               dbg_info *dbgi       = get_dbg_info(&entry->source_position);
+               ident    *ident;
+               if(symbol != NULL) {
+                       ident = new_id_from_str(symbol->string);
+               } else {
+                       if(entry_type->kind == TYPE_COMPOUND_STRUCT) {
+                               create_struct_type(&entry_type->compound, irtype, &offset,
+                                                  &align_all);
+                               continue;
+                       } else if(entry_type->kind == TYPE_COMPOUND_UNION) {
+                               create_union_type(&entry_type->compound, irtype, &offset,
+                                                 &align_all);
+                               continue;
+                       } else {
+                               assert(entry_type->kind == TYPE_BITFIELD);
+                       }
+                       ident = unique_ident("anon");
+               }
+
                ir_type *base_irtype;
                if(entry_type->kind == TYPE_BITFIELD) {
                        base_irtype = get_ir_type(entry_type->bitfield.base);
@@ -577,16 +609,8 @@ static ir_type *create_struct_type(compound_type_t *type)
                size_t entry_alignment = get_type_alignment_bytes(base_irtype);
                size_t misalign        = offset % entry_alignment;
 
-               dbg_info  *dbgi   = get_dbg_info(&entry->source_position);
-               ir_entity *entity = NULL;
-               if(entry->symbol != NULL) {
-                       ident   *ident        = new_id_from_str(entry->symbol->string);
-                       ir_type *entry_irtype = get_ir_type(entry_type);
-                       entity = new_d_entity(irtype, ident, entry_irtype, dbgi);
-               } else {
-                       /* only bitfields are allowed to be anonymous */
-                       assert(entry_type->kind == TYPE_BITFIELD);
-               }
+               ir_type   *entry_irtype = get_ir_type(entry_type);
+               ir_entity *entity = new_d_entity(irtype, ident, entry_irtype, dbgi);
 
                size_t base;
                size_t bits_remainder;
@@ -627,66 +651,100 @@ static ir_type *create_struct_type(compound_type_t *type)
                        align_all = entry_alignment;
                }
 
-               if(entity != NULL) {
-                       set_entity_offset(entity, base);
-                       set_entity_offset_bits_remainder(entity,
-                                                        (unsigned char) bits_remainder);
-                       add_struct_member(irtype, entity);
-                       entry->declaration_kind = DECLARATION_KIND_COMPOUND_MEMBER;
-                       assert(entry->v.entity == NULL);
-                       entry->v.entity         = entity;
-               }
+               set_entity_offset(entity, base);
+               set_entity_offset_bits_remainder(entity,
+                                                (unsigned char) bits_remainder);
+               //add_struct_member(irtype, entity);
+               entry->declaration_kind = DECLARATION_KIND_COMPOUND_MEMBER;
+               assert(entry->v.entity == NULL);
+               entry->v.entity         = entity;
        }
 
        size_t misalign = offset % align_all;
        if(misalign > 0 || bit_offset > 0) {
                offset += align_all - misalign;
        }
-       set_type_alignment_bytes(irtype, align_all);
-       set_type_size_bytes(irtype, offset);
-       set_type_state(irtype, layout_fixed);
 
-       declaration->v.irtype = irtype;
+       if(outer_offset != NULL) {
+               *outer_offset = offset;
+               *outer_align  = align_all;
+       } else {
+               set_type_alignment_bytes(irtype, align_all);
+               set_type_size_bytes(irtype, offset);
+               set_type_state(irtype, layout_fixed);
+       }
 
        return irtype;
 }
 
-static ir_type *create_union_type(compound_type_t *type)
+static ir_type *create_union_type(compound_type_t *type, ir_type *irtype,
+                                  size_t *outer_offset, size_t *outer_align)
 {
        declaration_t *declaration = type->declaration;
        if(declaration->v.irtype != NULL) {
                return declaration->v.irtype;
        }
 
-       symbol_t      *symbol      = declaration->symbol;
-       ident         *id;
-       if(symbol != NULL) {
-               id = unique_ident(symbol->string);
+       size_t offset    = 0;
+       size_t align_all = 1;
+       size_t size      = 0;
+
+       if(irtype == NULL) {
+               symbol_t      *symbol      = declaration->symbol;
+               ident         *id;
+               if(symbol != NULL) {
+                       id = unique_ident(symbol->string);
+               } else {
+                       id = unique_ident("__anonymous_union");
+               }
+               dbg_info *dbgi = get_dbg_info(&type->type.source_position);
+
+               irtype = new_d_type_union(id, dbgi);
        } else {
-               id = unique_ident("__anonymous_union");
+               offset    = *outer_offset;
+               align_all = *outer_align;
        }
-       dbg_info *dbgi  = get_dbg_info(&type->type.source_position);
-       ir_type *irtype = new_d_type_union(id, dbgi);
 
        type->type.firm_type = irtype;
 
-       int align_all = 1;
-       int size      = 0;
        declaration_t *entry = declaration->scope.declarations;
        for( ; entry != NULL; entry = entry->next) {
                if(entry->namespc != NAMESPACE_NORMAL)
                        continue;
 
-               ident   *ident         = new_id_from_str(entry->symbol->string);
-               ir_type *entry_ir_type = get_ir_type(entry->type);
+               type_t  *entry_type    = skip_typeref(entry->type);
+               ir_type *entry_ir_type = get_ir_type(entry_type);
 
-               int entry_size      = get_type_size_bytes(entry_ir_type);
-               int entry_alignment = get_type_alignment_bytes(entry_ir_type);
+               ident *ident;
+               if(entry->symbol != NULL) {
+                       ident = new_id_from_str(entry->symbol->string);
+               } else {
+                       size_t offs = offset;
+                       if(entry_type->kind == TYPE_COMPOUND_STRUCT) {
+                               create_struct_type(&entry_type->compound, irtype, &offs,
+                                                  &align_all);
+                               continue;
+                       } else if(entry_type->kind == TYPE_COMPOUND_UNION) {
+                               create_union_type(&entry_type->compound, irtype, &offs,
+                                                 &align_all);
+                               continue;
+                       } else {
+                               panic("anonymous union member must be struct or union");
+                       }
+                       size_t entry_size = offs - offset;
+                       if(entry_size > size) {
+                               size = entry_size;
+                       }
+                       ident = unique_ident("anon");
+               }
+
+               size_t entry_size      = get_type_size_bytes(entry_ir_type);
+               size_t entry_alignment = get_type_alignment_bytes(entry_ir_type);
 
                dbg_info  *const dbgi   = get_dbg_info(&entry->source_position);
                ir_entity *const entity = new_d_entity(irtype, ident, entry_ir_type,
                                                       dbgi);
-               add_union_member(irtype, entity);
+               //add_union_member(irtype, entity);
                set_entity_offset(entity, 0);
                entry->declaration_kind = DECLARATION_KIND_COMPOUND_MEMBER;
                assert(entry->v.entity == NULL);
@@ -703,11 +761,26 @@ static ir_type *create_union_type(compound_type_t *type)
                }
        }
 
-       set_type_alignment_bytes(irtype, align_all);
-       set_type_size_bytes(irtype, size);
-       set_type_state(irtype, layout_fixed);
+       if(outer_offset != NULL) {
+               assert(*outer_offset == offset);
 
-       declaration->v.irtype = irtype;
+               size_t misalign = offset % align_all;
+               if (misalign != 0)
+                       size += align_all - misalign;
+               *outer_offset += size;
+
+               if(align_all > *outer_align) {
+                       if(align_all % *outer_align != 0) {
+                               panic("uneven alignments not supported yet");
+                       }
+                       *outer_align = align_all;
+               }
+       } else {
+               set_type_alignment_bytes(irtype, align_all);
+               set_type_size_bytes(irtype, size);
+               set_type_state(irtype, layout_fixed);
+               declaration->v.irtype = irtype;
+       }
 
        return irtype;
 }
@@ -773,10 +846,10 @@ static ir_type *get_ir_type(type_t *type)
                firm_type = create_array_type(&type->array);
                break;
        case TYPE_COMPOUND_STRUCT:
-               firm_type = create_struct_type(&type->compound);
+               firm_type = create_struct_type(&type->compound, NULL, NULL, NULL);
                break;
        case TYPE_COMPOUND_UNION:
-               firm_type = create_union_type(&type->compound);
+               firm_type = create_union_type(&type->compound, NULL, NULL, NULL);
                break;
        case TYPE_ENUM:
                firm_type = create_enum_type(&type->enumt);
@@ -1568,12 +1641,13 @@ static bool is_local_variable(expression_t *expression)
        return declaration->declaration_kind == DECLARATION_KIND_LOCAL_VARIABLE;
 }
 
-static pn_Cmp get_pnc(const expression_kind_t kind)
+static pn_Cmp get_pnc(const expression_kind_t kind, type_t *const type)
 {
        switch(kind) {
        case EXPR_BINARY_EQUAL:         return pn_Cmp_Eq;
        case EXPR_BINARY_ISLESSGREATER: return pn_Cmp_Lg;
-       case EXPR_BINARY_NOTEQUAL:      return pn_Cmp_Ne;
+       case EXPR_BINARY_NOTEQUAL:
+               return is_type_float(skip_typeref(type)) ? pn_Cmp_Ne : pn_Cmp_Lg;
        case EXPR_BINARY_ISLESS:
        case EXPR_BINARY_LESS:          return pn_Cmp_Lt;
        case EXPR_BINARY_ISLESSEQUAL:
@@ -1611,7 +1685,7 @@ static ir_node *handle_assume_compare(dbg_info *dbi,
        ir_node       *res = NULL;
        pn_Cmp         cmp_val;
 
-       cmp_val = get_pnc(expression->base.kind);
+       cmp_val = get_pnc(expression->base.kind, op1->base.type);
 
        if (is_local_variable(op1) && is_local_variable(op2)) {
        var  = op1->reference.declaration;
@@ -2091,7 +2165,7 @@ static ir_node *binary_expression_to_firm(const binary_expression_t *expression)
                ir_node *left  = expression_to_firm(expression->left);
                ir_node *right = expression_to_firm(expression->right);
                ir_node *cmp   = new_d_Cmp(dbgi, left, right);
-               long     pnc   = get_pnc(kind);
+               long     pnc   = get_pnc(kind, expression->left->base.type);
                ir_node *proj  = new_d_Proj(dbgi, cmp, mode_b, pnc);
                return proj;
        }
@@ -2723,8 +2797,9 @@ struct compound_graph_path_entry_t {
        compound_graph_path_entry_t *prev;
 };
 
-static void create_initializer_object(initializer_t *initializer, type_t *type,
-               ir_entity *entity, compound_graph_path_entry_t *entry, int len);
+static void create_ir_initializer_object(initializer_t *initializer,
+               type_t *type, ir_entity *entity, compound_graph_path_entry_t *entry,
+               int len);
 
 static compound_graph_path *create_compound_path(ir_type *type,
                compound_graph_path_entry_t *entry, int len)
@@ -2746,10 +2821,10 @@ static compound_graph_path *create_compound_path(ir_type *type,
        return path;
 }
 
-static void create_initializer_value(initializer_value_t *initializer,
-                                     ir_entity *entity,
-                                     compound_graph_path_entry_t *entry,
-                                     int len)
+static void create_ir_initializer_value(initializer_value_t *initializer,
+                                        ir_entity *entity,
+                                        compound_graph_path_entry_t *entry,
+                                        int len)
 {
        ir_node             *node = expression_to_firm(initializer->value);
        ir_type             *type = get_entity_type(entity);
@@ -2757,11 +2832,9 @@ static void create_initializer_value(initializer_value_t *initializer,
        add_compound_ent_value_w_path(entity, node, path);
 }
 
-static void create_initializer_compound(initializer_list_t *initializer,
-                                        compound_type_t *type,
-                                        ir_entity *entity,
-                                        compound_graph_path_entry_t *last_entry,
-                                        int len)
+static void create_ir_initializer_compound(initializer_list_t *initializer,
+               compound_type_t *type, ir_entity *entity,
+               compound_graph_path_entry_t *last_entry, int len)
 {
        declaration_t *compound_declaration = type->declaration;
 
@@ -2791,22 +2864,22 @@ static void create_initializer_compound(initializer_list_t *initializer,
                                == DECLARATION_KIND_COMPOUND_MEMBER);
 
                if(sub_initializer->kind == INITIALIZER_VALUE) {
-                       create_initializer_value(&sub_initializer->value,
-                                                entity, &entry, len);
+                       create_ir_initializer_value(&sub_initializer->value,
+                                                   entity, &entry, len);
                } else {
                        type_t *entry_type = skip_typeref(compound_entry->type);
-                       create_initializer_object(sub_initializer, entry_type, entity,
-                                                 &entry, len);
+                       create_ir_initializer_object(sub_initializer, entry_type, entity,
+                                                    &entry, len);
                }
 
                ++i;
        }
 }
 
-static void create_initializer_array(initializer_list_t *initializer,
-                                     array_type_t *type, ir_entity *entity,
-                                     compound_graph_path_entry_t *last_entry,
-                                     int len)
+static void create_ir_initializer_array(initializer_list_t *initializer,
+                                        array_type_t *type, ir_entity *entity,
+                                        compound_graph_path_entry_t *last_entry,
+                                        int len)
 {
        type_t *element_type = type->element_type;
        element_type         = skip_typeref(element_type);
@@ -2823,10 +2896,10 @@ static void create_initializer_array(initializer_list_t *initializer,
                initializer_t *sub_initializer = initializer->initializers[i];
 
                if(sub_initializer->kind == INITIALIZER_VALUE) {
-                       create_initializer_value(&sub_initializer->value,
+                       create_ir_initializer_value(&sub_initializer->value,
                                                 entity, &entry, len);
                } else {
-                       create_initializer_object(sub_initializer, element_type, entity,
+                       create_ir_initializer_object(sub_initializer, element_type, entity,
                                                  &entry, len);
                }
        }
@@ -2842,10 +2915,9 @@ static void create_initializer_array(initializer_list_t *initializer,
 #endif
 }
 
-static void create_initializer_string(initializer_string_t *initializer,
-                                      array_type_t *type, ir_entity *entity,
-                                      compound_graph_path_entry_t *last_entry,
-                                      int len)
+static void create_ir_initializer_string(initializer_string_t *initializer,
+               array_type_t *type, ir_entity *entity,
+               compound_graph_path_entry_t *last_entry, int len)
 {
        type_t *element_type = type->element_type;
        element_type         = skip_typeref(element_type);
@@ -2870,10 +2942,10 @@ static void create_initializer_string(initializer_string_t *initializer,
        }
 }
 
-static void create_initializer_wide_string(
-       const initializer_wide_string_t *const initializer, array_type_t *const type,
-       ir_entity *const entity, compound_graph_path_entry_t *const last_entry,
-       int len)
+static void create_ir_initializer_wide_string(
+               const initializer_wide_string_t *const initializer,
+               array_type_t *const type, ir_entity *const entity,
+               compound_graph_path_entry_t *const last_entry, int len)
 {
        type_t *element_type = type->element_type;
        element_type         = skip_typeref(element_type);
@@ -2896,8 +2968,9 @@ static void create_initializer_wide_string(
        }
 }
 
-static void create_initializer_object(initializer_t *initializer, type_t *type,
-               ir_entity *entity, compound_graph_path_entry_t *entry, int len)
+static void create_ir_initializer_object(initializer_t *initializer,
+               type_t *type, ir_entity *entity, compound_graph_path_entry_t *entry,
+               int len)
 {
        if(is_type_array(type)) {
                array_type_t *array_type = &type->array;
@@ -2905,19 +2978,23 @@ static void create_initializer_object(initializer_t *initializer, type_t *type,
                switch (initializer->kind) {
                        case INITIALIZER_STRING: {
                                initializer_string_t *const string = &initializer->string;
-                               create_initializer_string(string, array_type, entity, entry, len);
+                               create_ir_initializer_string(string, array_type, entity, entry,
+                                                            len);
                                return;
                        }
 
                        case INITIALIZER_WIDE_STRING: {
-                               initializer_wide_string_t *const string = &initializer->wide_string;
-                               create_initializer_wide_string(string, array_type, entity, entry, len);
+                               initializer_wide_string_t *const string
+                                       = &initializer->wide_string;
+                               create_ir_initializer_wide_string(string, array_type, entity,
+                                                                 entry, len);
                                return;
                        }
 
                        case INITIALIZER_LIST: {
                                initializer_list_t *const list = &initializer->list;
-                               create_initializer_array(list, array_type, entity, entry, len);
+                               create_ir_initializer_array(list, array_type, entity, entry,
+                                                           len);
                                return;
                        }
 
@@ -2931,7 +3008,7 @@ static void create_initializer_object(initializer_t *initializer, type_t *type,
 
                assert(is_type_compound(type));
                compound_type_t *compound_type = &type->compound;
-               create_initializer_compound(list, compound_type, entity, entry, len);
+               create_ir_initializer_compound(list, compound_type, entity, entry, len);
        }
 }
 
@@ -2969,7 +3046,7 @@ static void create_initializer_local_variable_entity(declaration_t *declaration)
        current_ir_graph = get_const_code_irg();
 
        type_t *const type = skip_typeref(declaration->type);
-       create_initializer_object(initializer, type, init_entity, NULL, 0);
+       create_ir_initializer_object(initializer, type, init_entity, NULL, 0);
 
        assert(current_ir_graph == get_const_code_irg());
        current_ir_graph = old_current_ir_graph;
@@ -2981,7 +3058,7 @@ static void create_initializer_local_variable_entity(declaration_t *declaration)
        set_store(copyb_mem);
 }
 
-static void create_initializer(declaration_t *declaration)
+static void create_ir_initializer(declaration_t *declaration)
 {
        initializer_t *initializer = declaration->init.initializer;
        if(initializer == NULL)
@@ -3017,7 +3094,7 @@ static void create_initializer(declaration_t *declaration)
                set_entity_variability(entity, variability_initialized);
 
                type_t *type = skip_typeref(declaration->type);
-               create_initializer_object(initializer, type, entity, NULL, 0);
+               create_ir_initializer_object(initializer, type, entity, NULL, 0);
        }
 }
 
@@ -3047,7 +3124,7 @@ static void create_local_variable(declaration_t *declaration)
                ++next_value_number_function;
        }
 
-       create_initializer(declaration);
+       create_ir_initializer(declaration);
 }
 
 static void create_local_static_variable(declaration_t *declaration)
@@ -3071,7 +3148,7 @@ static void create_local_static_variable(declaration_t *declaration)
        ir_graph *const old_current_ir_graph = current_ir_graph;
        current_ir_graph = get_const_code_irg();
 
-       create_initializer(declaration);
+       create_ir_initializer(declaration);
 
        assert(current_ir_graph == get_const_code_irg());
        current_ir_graph = old_current_ir_graph;
@@ -3151,6 +3228,60 @@ static ir_node *compound_statement_to_firm(compound_statement_t *compound)
        return result;
 }
 
+static void create_global_variable(declaration_t *declaration)
+{
+       ir_visibility  vis;
+       ir_type       *var_type;
+       switch ((storage_class_tag_t)declaration->storage_class) {
+               case STORAGE_CLASS_STATIC:
+                       vis = visibility_local;
+                       goto global_var;
+
+               case STORAGE_CLASS_EXTERN:
+                       vis = visibility_external_allocated;
+                       goto global_var;
+
+               case STORAGE_CLASS_NONE:
+                       vis = visibility_external_visible;
+                       goto global_var;
+
+               case STORAGE_CLASS_THREAD:
+                       vis = visibility_external_visible;
+                       goto tls_var;
+
+               case STORAGE_CLASS_THREAD_EXTERN:
+                       vis = visibility_external_allocated;
+                       goto tls_var;
+
+               case STORAGE_CLASS_THREAD_STATIC:
+                       vis = visibility_local;
+                       goto tls_var;
+
+tls_var:
+                       var_type = get_tls_type();
+                       goto create_var;
+
+global_var:
+                       var_type = get_glob_type();
+                       goto create_var;
+
+create_var:
+                       create_declaration_entity(declaration,
+                                                 DECLARATION_KIND_GLOBAL_VARIABLE,
+                                                 var_type);
+                       set_entity_visibility(declaration->v.entity, vis);
+
+                       return;
+
+               case STORAGE_CLASS_TYPEDEF:
+               case STORAGE_CLASS_AUTO:
+               case STORAGE_CLASS_REGISTER:
+               case STORAGE_CLASS_ENUM_ENTRY:
+                       break;
+       }
+       panic("Invalid storage class for global variable");
+}
+
 static void create_local_declaration(declaration_t *declaration)
 {
        if(declaration->symbol == NULL)
@@ -3165,12 +3296,18 @@ static void create_local_declaration(declaration_t *declaration)
        case STORAGE_CLASS_ENUM_ENTRY:
                panic("enum entry declaration in local block found");
        case STORAGE_CLASS_EXTERN:
-               panic("extern declaration in local block found");
+               create_global_variable(declaration);
+               create_ir_initializer(declaration);
+               return;
        case STORAGE_CLASS_NONE:
        case STORAGE_CLASS_AUTO:
        case STORAGE_CLASS_REGISTER:
                if(is_type_function(type)) {
-                       panic("nested functions not supported yet");
+                       if(declaration->init.statement != NULL) {
+                               panic("nested functions not supported yet");
+                       } else {
+                               get_function_entity(declaration);
+                       }
                } else {
                        create_local_variable(declaration);
                }
@@ -3767,6 +3904,14 @@ static int count_decls_in_expression(const expression_t *expression) {
        }
        EXPR_UNARY_CASES
                return count_decls_in_expression(expression->unary.value);
+       case EXPR_CALL: {
+               int count = 0;
+               call_argument_t *argument = expression->call.arguments;
+               for( ; argument != NULL; argument = argument->next) {
+                       count += count_decls_in_expression(argument->expression);
+               }
+               return count;
+       }
 
        default:
                break;
@@ -4071,62 +4216,6 @@ static void create_function(declaration_t *declaration)
        irg_vrfy(irg);
 }
 
-static void create_global_variable(declaration_t *declaration)
-{
-       ir_visibility  vis;
-       ir_type       *var_type;
-       switch ((storage_class_tag_t)declaration->storage_class) {
-               case STORAGE_CLASS_STATIC:
-                       vis = visibility_local;
-                       goto global_var;
-
-               case STORAGE_CLASS_EXTERN:
-                       vis = visibility_external_allocated;
-                       goto global_var;
-
-               case STORAGE_CLASS_NONE:
-                       vis = visibility_external_visible;
-                       goto global_var;
-
-               case STORAGE_CLASS_THREAD:
-                       vis = visibility_external_visible;
-                       goto tls_var;
-
-               case STORAGE_CLASS_THREAD_EXTERN:
-                       vis = visibility_external_allocated;
-                       goto tls_var;
-
-               case STORAGE_CLASS_THREAD_STATIC:
-                       vis = visibility_local;
-                       goto tls_var;
-
-tls_var:
-                       var_type = get_tls_type();
-                       goto create_var;
-
-global_var:
-                       var_type = get_glob_type();
-                       goto create_var;
-
-create_var:
-                       create_declaration_entity(declaration,
-                                                 DECLARATION_KIND_GLOBAL_VARIABLE,
-                                                 var_type);
-                       set_entity_visibility(declaration->v.entity, vis);
-
-                       current_ir_graph = get_const_code_irg();
-                       create_initializer(declaration);
-                       return;
-
-               case STORAGE_CLASS_TYPEDEF:
-               case STORAGE_CLASS_AUTO:
-               case STORAGE_CLASS_REGISTER:
-               case STORAGE_CLASS_ENUM_ENTRY:
-                       break;
-       }
-       panic("Invalid storage class for global variable");
-}
-
 static void scope_to_firm(scope_t *scope)
 {
        /* first pass: create declarations */
@@ -4148,7 +4237,7 @@ static void scope_to_firm(scope_t *scope)
                }
        }
 
-       /* second pass: create code */
+       /* second pass: create code/initializers */
        declaration = scope->declarations;
        for( ; declaration != NULL; declaration = declaration->next) {
                if(declaration->namespc != NAMESPACE_NORMAL)
@@ -4160,10 +4249,14 @@ static void scope_to_firm(scope_t *scope)
                        continue;
 
                type_t *type = declaration->type;
-               if(type->kind != TYPE_FUNCTION)
-                       continue;
-
-               create_function(declaration);
+               if(type->kind == TYPE_FUNCTION) {
+                       create_function(declaration);
+               } else {
+                       assert(declaration->declaration_kind
+                                       == DECLARATION_KIND_GLOBAL_VARIABLE);
+                       current_ir_graph = get_const_code_irg();
+                       create_ir_initializer(declaration);
+               }
        }
 }