- change enum to have an underlying atomic type
[cparser] / ast2firm.c
index 817c990..a6eb917 100644 (file)
@@ -265,7 +265,7 @@ static unsigned get_type_size_const(type_t *type)
        case TYPE_IMAGINARY:
                return get_atomic_type_size(type->imaginary.akind);
        case TYPE_ENUM:
-               return get_mode_size_bytes(mode_int);
+               return get_atomic_type_size(type->enumt.akind);
        case TYPE_COMPOUND_UNION:
        case TYPE_COMPOUND_STRUCT:
                return get_compound_type_size(&type->compound);
@@ -329,17 +329,34 @@ static unsigned count_parameters(const function_type_t *function_type)
        return count;
 }
 
+static type_t *get_aligned_type(type_t *type, int alignment)
+{
+       if (alignment == 0)
+               return type;
+
+       type = skip_typeref(type);
+       if (alignment > type->base.alignment) {
+               type_t *copy = duplicate_type(type);
+               copy->base.alignment = alignment;
+
+               type = typehash_insert(copy);
+               if (type != copy) {
+                       obstack_free(type_obst, copy);
+               }
+       }
+       return type;
+}
+
 /**
  * Creates a Firm type for an atomic type
  */
-static ir_type *create_atomic_type(const atomic_type_t *type)
+static ir_type *create_atomic_type(atomic_type_kind_t akind, int alignment)
 {
-       atomic_type_kind_t  kind   = type->akind;
-       ir_mode            *mode   = atomic_modes[kind];
+       ir_mode            *mode   = atomic_modes[akind];
        ident              *id     = get_mode_ident(mode);
        ir_type            *irtype = new_type_primitive(id, mode);
 
-       set_type_alignment_bytes(irtype, type->base.alignment);
+       set_type_alignment_bytes(irtype, alignment);
 
        return irtype;
 }
@@ -653,6 +670,8 @@ static ir_type *create_compound_type(compound_type_t *type, ir_type *irtype,
 
                symbol_t *symbol     = entry->base.symbol;
                type_t   *entry_type = skip_typeref(entry->declaration.type);
+               entry_type
+                       = get_aligned_type(entry_type, entry->compound_member.alignment);
                dbg_info *dbgi       = get_dbg_info(&entry->base.source_position);
 
                ident    *ident;
@@ -806,7 +825,7 @@ static ir_type *create_enum_type(enum_type_t *const type)
 
        constant_folding = constant_folding_old;
 
-       return ir_type_int;
+       return create_atomic_type(type->akind, type->base.alignment);
 }
 
 static ir_type *get_ir_type_incomplete(type_t *type)
@@ -846,10 +865,11 @@ ir_type *get_ir_type(type_t *type)
        switch (type->kind) {
        case TYPE_ERROR:
                /* Happens while constant folding, when there was an error */
-               return create_atomic_type(&type_void->atomic);
+               return create_atomic_type(ATOMIC_TYPE_VOID, 0);
 
        case TYPE_ATOMIC:
-               firm_type = create_atomic_type(&type->atomic);
+               firm_type = create_atomic_type(type->atomic.akind,
+                                              type->base.alignment);
                break;
        case TYPE_COMPLEX:
                firm_type = create_complex_type(&type->complex);
@@ -1359,16 +1379,14 @@ static ir_node *deref_address(dbg_info *const dbgi, type_t *const type,
                return addr;
        }
 
+       cons_flags     flags    = type->base.qualifiers & TYPE_QUALIFIER_VOLATILE
+                                 ? cons_volatile : 0;
        ir_mode *const mode     = get_type_mode(irtype);
        ir_node *const memory   = get_store();
-       ir_node *const load     = new_d_Load(dbgi, memory, addr, mode);
+       ir_node *const load     = new_d_Load(dbgi, memory, addr, mode, flags);
        ir_node *const load_mem = new_d_Proj(dbgi, load, mode_M, pn_Load_M);
        ir_node *const load_res = new_d_Proj(dbgi, load, mode,   pn_Load_res);
 
-       if (type->base.qualifiers & TYPE_QUALIFIER_VOLATILE && !is_Bad(load)) {
-               set_Load_volatility(load, volatility_is_volatile);
-       }
-
        set_store(load_mem);
 
        ir_mode *const mode_arithmetic = get_ir_mode_arithmetic(type);
@@ -1798,10 +1816,10 @@ static void assign_value(dbg_info *dbgi, ir_node *addr, type_t *type,
        ir_node *memory = get_store();
 
        if (is_type_scalar(type)) {
-               ir_node  *store     = new_d_Store(dbgi, memory, addr, value);
+               cons_flags flags    = type->base.qualifiers & TYPE_QUALIFIER_VOLATILE
+                                     ? cons_volatile : 0;
+               ir_node  *store     = new_d_Store(dbgi, memory, addr, value, flags);
                ir_node  *store_mem = new_d_Proj(dbgi, store, mode_M, pn_Store_M);
-               if (type->base.qualifiers & TYPE_QUALIFIER_VOLATILE && !is_Bad(store))
-                       set_Store_volatility(store, volatility_is_volatile);
                set_store(store_mem);
        } else {
                ir_type *irtype    = get_ir_type(type);
@@ -1856,7 +1874,8 @@ static ir_node *bitfield_store_to_firm(dbg_info *dbgi,
 
        /* load current value */
        ir_node  *mem             = get_store();
-       ir_node  *load            = new_d_Load(dbgi, mem, addr, mode);
+       ir_node  *load            = new_d_Load(dbgi, mem, addr, mode,
+                                       set_volatile ? cons_volatile : 0);
        ir_node  *load_mem        = new_d_Proj(dbgi, load, mode_M, pn_Load_M);
        ir_node  *load_res        = new_d_Proj(dbgi, load, mode, pn_Load_res);
        tarval   *shift_mask      = create_bitfield_mask(mode, bitoffset, bitsize);
@@ -1866,17 +1885,11 @@ static ir_node *bitfield_store_to_firm(dbg_info *dbgi,
 
        /* construct new value and store */
        ir_node *new_val   = new_d_Or(dbgi, load_res_masked, value_maskshift, mode);
-       ir_node *store     = new_d_Store(dbgi, load_mem, addr, new_val);
+       ir_node *store     = new_d_Store(dbgi, load_mem, addr, new_val,
+                                        set_volatile ? cons_volatile : 0);
        ir_node *store_mem = new_d_Proj(dbgi, store, mode_M, pn_Store_M);
        set_store(store_mem);
 
-       if (set_volatile) {
-               if (!is_Bad(load))
-                       set_Load_volatility(load, volatility_is_volatile);
-               if (!is_Bad(store))
-                       set_Store_volatility(store, volatility_is_volatile);
-       }
-
        return value_masked;
 }
 
@@ -1887,7 +1900,7 @@ static ir_node *bitfield_extract_to_firm(const select_expression_t *expression,
        type_t   *type     = expression->base.type;
        ir_mode  *mode     = get_ir_mode_storage(type);
        ir_node  *mem      = get_store();
-       ir_node  *load     = new_d_Load(dbgi, mem, addr, mode);
+       ir_node  *load     = new_d_Load(dbgi, mem, addr, mode, 0);
        ir_node  *load_mem = new_d_Proj(dbgi, load, mode_M, pn_Load_M);
        ir_node  *load_res = new_d_Proj(dbgi, load, mode, pn_Load_res);
 
@@ -3405,10 +3418,13 @@ static void create_variable_entity(entity_t *variable,
                                    ir_type *parent_type)
 {
        assert(variable->kind == ENTITY_VARIABLE);
-       type_t    *const type     = skip_typeref(variable->declaration.type);
+       type_t    *type = skip_typeref(variable->declaration.type);
+       type            = get_aligned_type(type, variable->variable.alignment);
+
        ident     *const id       = new_id_from_str(variable->base.symbol->string);
        ir_type   *const irtype   = get_ir_type(type);
        dbg_info  *const dbgi     = get_dbg_info(&variable->base.source_position);
+
        ir_entity *const irentity = new_d_entity(parent_type, id, irtype, dbgi);
 
        handle_gnu_attributes_ent(irentity, variable);
@@ -3417,6 +3433,7 @@ static void create_variable_entity(entity_t *variable,
        variable->variable.v.entity = irentity;
        set_entity_variability(irentity, variability_uninitialized);
        set_entity_ld_ident(irentity, create_ld_ident(variable));
+
        if (parent_type == get_tls_type())
                set_entity_allocation(irentity, allocation_automatic);
        else if (declaration_kind == DECLARATION_KIND_GLOBAL_VARIABLE)
@@ -3851,7 +3868,7 @@ static void create_dynamic_null_initializer(ir_type *type, dbg_info *dbgi,
 
                /* TODO: bitfields */
                ir_node *mem    = get_store();
-               ir_node *store  = new_d_Store(dbgi, mem, base_addr, cnst);
+               ir_node *store  = new_d_Store(dbgi, mem, base_addr, cnst, 0);
                ir_node *proj_m = new_Proj(store, mode_M, pn_Store_M);
                set_store(proj_m);
        } else {
@@ -3909,7 +3926,7 @@ static void create_dynamic_initializer_sub(ir_initializer_t *initializer,
 
                assert(get_type_mode(type) == mode);
                ir_node *mem    = get_store();
-               ir_node *store  = new_d_Store(dbgi, mem, base_addr, node);
+               ir_node *store  = new_d_Store(dbgi, mem, base_addr, node, 0);
                ir_node *proj_m = new_Proj(store, mode_M, pn_Store_M);
                set_store(proj_m);
                return;
@@ -3929,7 +3946,7 @@ static void create_dynamic_initializer_sub(ir_initializer_t *initializer,
 
                assert(get_type_mode(type) == mode);
                ir_node *mem    = get_store();
-               ir_node *store  = new_d_Store(dbgi, mem, base_addr, cnst);
+               ir_node *store  = new_d_Store(dbgi, mem, base_addr, cnst, 0);
                ir_node *proj_m = new_Proj(store, mode_M, pn_Store_M);
                set_store(proj_m);
                return;
@@ -4051,6 +4068,8 @@ static void create_initializer_local_variable_entity(entity_t *entity)
        dbg_info      *dbgi        = get_dbg_info(&entity->base.source_position);
        ir_entity     *irentity    = entity->variable.v.entity;
        type_t        *type        = entity->declaration.type;
+
+       type = get_aligned_type(type, entity->variable.alignment);
        create_local_initializer(initializer, dbgi, irentity, type);
 }
 
@@ -4189,7 +4208,9 @@ static void create_local_static_variable(entity_t *entity)
        assert(entity->kind == ENTITY_VARIABLE);
        assert(entity->declaration.kind == DECLARATION_KIND_UNKNOWN);
 
-       type_t    *const type     = skip_typeref(entity->declaration.type);
+       type_t    *type = skip_typeref(entity->declaration.type);
+       type            = get_aligned_type(type, entity->variable.alignment);
+
        ir_type   *const var_type = entity->variable.thread_local ?
                get_tls_type() : get_glob_type();
        ir_type   *const irtype   = get_ir_type(type);
@@ -4208,6 +4229,7 @@ static void create_local_static_variable(entity_t *entity)
 
        entity->declaration.kind  = DECLARATION_KIND_GLOBAL_VARIABLE;
        entity->variable.v.entity = irentity;
+
        set_entity_ld_ident(irentity, id);
        set_entity_variability(irentity, variability_uninitialized);
        set_entity_visibility(irentity, visibility_local);