fixed some warnings
[cparser] / ast2firm.c
index c7764f4..11f3bd7 100644 (file)
@@ -28,6 +28,8 @@ static type_t *type_const_char;
 static type_t *type_void;
 static type_t *type_int;
 
+static symbol_t *symbol_alloca;
+
 static int       next_value_number_function;
 static ir_node  *continue_label;
 static ir_node  *break_label;
@@ -97,6 +99,8 @@ void init_ast2firm(void)
                                              ir_type_void, mode_P_data);
 
        type_void->firm_type = ir_type_void;
+
+       symbol_alloca = symbol_table_insert("__builtin_alloca");
 }
 
 void exit_ast2firm(void)
@@ -559,15 +563,15 @@ static ir_node *const_to_firm(const const_t *cnst)
        tarval *tv;
        size_t  len;
        if(mode_is_float(mode)) {
-               len = snprintf(buf, sizeof(buf), "%LF", cnst->v.float_value);
+               tv = new_tarval_from_double(cnst->v.float_value, mode);
        } else {
                if(mode_is_signed(mode)) {
                        len = snprintf(buf, sizeof(buf), "%lld", cnst->v.int_value);
                } else {
                        len = snprintf(buf, sizeof(buf), "%llu", cnst->v.int_value);
                }
+               tv = new_tarval_from_str(buf, len, mode);
        }
-       tv = new_tarval_from_str(buf, len, mode);
 
        return new_d_Const(dbgi, mode, tv);
 }
@@ -712,11 +716,43 @@ static ir_node *reference_addr(const reference_expression_t *ref)
        panic("reference to declaration with unknown type found");
 }
 
+static ir_node *process_builtin_call(const call_expression_t *call)
+{
+       dbg_info *dbgi = get_dbg_info(&call->expression.source_position);
+
+       assert(call->function->type == EXPR_BUILTIN_SYMBOL);
+       builtin_symbol_expression_t *builtin
+               = (builtin_symbol_expression_t*) call->function;
+       symbol_t *symbol = builtin->symbol;
+
+       if(symbol == symbol_alloca) {
+               if(call->arguments == NULL || call->arguments->next != NULL) {
+                       panic("invalid number of parameters on __builtin_alloca");
+               }
+               expression_t *argument = call->arguments->expression;
+               ir_node      *size     = expression_to_firm(argument);
+
+               ir_node *store  = get_store();
+               ir_node *alloca = new_d_Alloc(dbgi, store, size, firm_unknown_type,
+                                             stack_alloc);
+               ir_node *proj_m = new_Proj(alloca, mode_M, pn_Alloc_M);
+               set_store(proj_m);
+               ir_node *res    = new_Proj(alloca, mode_P_data, pn_Alloc_res);
+
+               return res;
+       } else {
+               panic("Unsupported builtin found\n");
+       }
+}
+
 static ir_node *call_expression_to_firm(const call_expression_t *call)
 {
        assert(get_cur_block() != NULL);
 
        expression_t  *function = call->function;
+       if(function->type == EXPR_BUILTIN_SYMBOL) {
+               return process_builtin_call(call);
+       }
        ir_node       *callee   = expression_to_firm(function);
 
        function_type_t *function_type;
@@ -792,6 +828,9 @@ static ir_node *call_expression_to_firm(const call_expression_t *call)
        return result;
 }
 
+static void statement_to_firm(statement_t *statement);
+static ir_node *compound_statement_to_firm(compound_statement_t *compound);
+
 static ir_node *expression_to_addr(const expression_t *expression);
 static void create_condition_evaluation(const expression_t *expression,
                                         ir_node *true_block,
@@ -856,7 +895,6 @@ static ir_node *create_incdec(const unary_expression_t *expression)
                offset = new_Const(mode, get_mode_one(mode));
        }
 
-       ir_node *new_value;
        switch(expression->type) {
        case UNEXPR_POSTFIX_INCREMENT: {
                ir_node *new_value = new_d_Add(dbgi, value_node, offset, mode);
@@ -880,15 +918,14 @@ static ir_node *create_incdec(const unary_expression_t *expression)
        }
        default:
                panic("no incdec expr in create_incdec");
+               return NULL;
        }
-
-       return new_value;
 }
 
 static ir_node *unary_expression_to_firm(const unary_expression_t *expression)
 {
        dbg_info *dbgi = get_dbg_info(&expression->expression.source_position);
-       type_t   *type = expression->expression.datatype;
+       type_t   *type = skip_typeref(expression->expression.datatype);
 
        if(expression->type == UNEXPR_TAKE_ADDRESS)
                return expression_to_addr(expression->value);
@@ -1078,10 +1115,19 @@ static ir_node *create_sub(const binary_expression_t *expression)
        type_t       *const type_left  = skip_typeref(expr_left->datatype);
        type_t       *const type_right = skip_typeref(expr_right->datatype);
 
-       if ((is_type_arithmetic(type_left) && is_type_arithmetic(type_right)) ||
-           (type_left->type == TYPE_POINTER && type_right->type == TYPE_POINTER)) {
+       if (is_type_arithmetic(type_left) && is_type_arithmetic(type_right)) {
                ir_mode *const mode = get_ir_mode(type);
                return new_d_Sub(dbgi, left, right, mode);
+       } else if (type_left->type == TYPE_POINTER && type_right->type == TYPE_POINTER) {
+               const pointer_type_t *const ptr_type = (const pointer_type_t*)type_left;
+               const unsigned elem_size             = get_type_size(ptr_type->points_to);
+               ir_mode *const mode   = get_ir_mode(type);
+               ir_node *const sub    = new_d_Sub(dbgi, left, right, mode);
+               ir_node *const cnst   = new_Const_long(mode_Is, (long)elem_size);
+               ir_node *const no_mem = new_NoMem();
+               ir_node *const div    = new_d_Div(dbgi, no_mem, sub, cnst, mode,
+                                                 op_pin_state_floats);
+               return new_d_Proj(dbgi, div, mode, pn_Div_res);
        }
 
        assert(type_left->type == TYPE_POINTER);
@@ -1102,9 +1148,11 @@ static ir_node *create_shift(const binary_expression_t *expression)
        ir_node *res;
 
        switch(expression->type) {
+       case BINEXPR_SHIFTLEFT_ASSIGN:
        case BINEXPR_SHIFTLEFT:
                res = new_d_Shl(dbgi, left, right, mode);
                break;
+       case BINEXPR_SHIFTRIGHT_ASSIGN:
        case BINEXPR_SHIFTRIGHT: {
                 expression_t *expr_left = expression->left;
                 type_t       *type_left = skip_typeref(expr_left->datatype);
@@ -1130,8 +1178,11 @@ static ir_node *create_divmod(const binary_expression_t *expression)
        ir_node  *left  = expression_to_firm(expression->left);
        ir_node  *right = expression_to_firm(expression->right);
        ir_node  *pin   = new_Pin(new_NoMem());
-       type_t   *type  = expression->expression.datatype;
+       /* be careful with the modes, because in arithmetic assign nodes only
+        * the right operand has the mode of the arithmetic already */
+       type_t   *type  = expression->right->datatype;
        ir_mode  *mode  = get_ir_mode(type);
+       left            = create_conv(dbgi, left, mode);
        ir_node  *op;
        ir_node  *res;
 
@@ -1176,6 +1227,19 @@ static ir_node *create_arithmetic_assign_divmod(
        return value;
 }
 
+static ir_node *create_arithmetic_assign_shift(
+               const binary_expression_t *expression)
+{
+       ir_node  *      value = create_shift(expression);
+       dbg_info *const dbgi  = get_dbg_info(&expression->expression.source_position);
+       type_t   *const type  = expression->expression.datatype;
+       ir_mode  *const mode  = get_ir_mode(type);
+
+       value = create_conv(dbgi, value, mode);
+       set_value_for_expression(expression->left, value);
+
+       return value;
+}
 
 static ir_node *binary_expression_to_firm(const binary_expression_t *expression)
 {
@@ -1239,9 +1303,8 @@ static ir_node *binary_expression_to_firm(const binary_expression_t *expression)
        case BINEXPR_BITWISE_XOR_ASSIGN:
                return create_arithmetic_assign_binop(expression, new_d_Eor);
        case BINEXPR_SHIFTLEFT_ASSIGN:
-               return create_arithmetic_assign_binop(expression, new_d_Shl);
        case BINEXPR_SHIFTRIGHT_ASSIGN:
-               return create_arithmetic_assign_binop(expression, new_d_Shr);
+               return create_arithmetic_assign_shift(expression);
        default:
                panic("TODO binexpr type");
        }
@@ -1250,10 +1313,22 @@ static ir_node *binary_expression_to_firm(const binary_expression_t *expression)
 static ir_node *array_access_addr(const array_access_expression_t *expression)
 {
        dbg_info *dbgi = get_dbg_info(&expression->expression.source_position);
+       ir_node  *base_addr;
+       ir_node  *offset;
 
-       ir_node *base_addr = expression_to_firm(expression->array_ref);
-       ir_node *offset    = expression_to_firm(expression->index);
-       offset             = create_conv(dbgi, offset, mode_Iu);
+       type_t   *type_left  = skip_typeref(expression->array_ref->datatype);
+       type_t   *type_right = skip_typeref(expression->index->datatype);
+
+       if(type_left->type == TYPE_POINTER || type_left->type == TYPE_ARRAY) {
+               base_addr = expression_to_firm(expression->array_ref);
+               offset    = expression_to_firm(expression->index);
+       } else {
+               assert(type_right->type == TYPE_POINTER
+                               || type_right->type == TYPE_ARRAY);
+               base_addr = expression_to_firm(expression->index);
+               offset    = expression_to_firm(expression->array_ref);
+       }
+       offset    = create_conv(dbgi, offset, mode_Iu);
 
        unsigned elem_size       = get_type_size(expression->expression.datatype);
        ir_node *elem_size_const = new_Const_long(mode_Iu, elem_size);
@@ -1470,6 +1545,14 @@ static ir_node *function_name_to_firm(const string_literal_t *const expr)
        return current_function_name;
 }
 
+static ir_node *statement_expression_to_firm(const statement_expression_t *expr)
+{
+       statement_t *statement = expr->statement;
+
+       assert(statement->type == STATEMENT_COMPOUND);
+       return compound_statement_to_firm((compound_statement_t*) statement);
+}
+
 static ir_node *dereference_addr(const unary_expression_t *const expression)
 {
        assert(expression->type == UNEXPR_DEREFERENCE);
@@ -1530,9 +1613,11 @@ static ir_node *_expression_to_firm(const expression_t *expression)
        case EXPR_FUNCTION:
        case EXPR_PRETTY_FUNCTION:
                return function_name_to_firm((const string_literal_t*)expression);
+       case EXPR_STATEMENT:
+               return statement_expression_to_firm(
+                               (const statement_expression_t*) expression);
        case EXPR_OFFSETOF:
        case EXPR_VA_ARG:
-       case EXPR_STATEMENT:
        case EXPR_BUILTIN_SYMBOL:
                panic("unimplemented expression found");
 
@@ -1626,7 +1711,6 @@ static void create_condition_evaluation(const expression_t *expression,
        set_cur_block(NULL);
 }
 
-static void statement_to_firm(statement_t *statement);
 
 static void return_statement_to_firm(return_statement_t *statement)
 {
@@ -1651,21 +1735,30 @@ static void return_statement_to_firm(return_statement_t *statement)
        set_cur_block(NULL);
 }
 
-static void compound_statement_to_firm(compound_statement_t *compound)
+static ir_node *expression_statement_to_firm(expression_statement_t *statement)
 {
+       if(get_cur_block() == NULL)
+               return NULL;
+
+       return expression_to_firm(statement->expression);
+}
+
+static ir_node *compound_statement_to_firm(compound_statement_t *compound)
+{
+       ir_node     *result    = NULL;
        statement_t *statement = compound->statements;
        for( ; statement != NULL; statement = statement->next) {
                //context2firm(&statement->context);
+
+               if(statement->next == NULL && statement->type == STATEMENT_EXPRESSION) {
+                       result = expression_statement_to_firm(
+                                       (expression_statement_t*) statement);
+                       break;
+               }
                statement_to_firm(statement);
        }
-}
 
-static void expression_statement_to_firm(expression_statement_t *statement)
-{
-       if(get_cur_block() == NULL)
-               return;
-
-       expression_to_firm(statement->expression);
+       return result;
 }
 
 static void if_statement_to_firm(if_statement_t *statement)
@@ -1925,19 +2018,12 @@ struct compound_graph_path_entry_t {
        compound_graph_path_entry_t *prev;
 };
 
-static void create_initializer_list(initializer_list_t *initializer,
-                                    type_t *type, ir_entity *entity,
-                                    compound_graph_path_entry_t *entry,
-                                    int len);
+static void create_initializer_object(initializer_t *initializer, type_t *type,
+               ir_entity *entity, compound_graph_path_entry_t *entry, int len);
 
-static void create_initializer_value(initializer_value_t *initializer,
-                                     ir_entity *entity,
-                                     compound_graph_path_entry_t *entry,
-                                     int len)
+static compound_graph_path *create_compound_path(ir_type *type,
+               compound_graph_path_entry_t *entry, int len)
 {
-       ir_node *node = expression_to_firm(initializer->value);
-
-       ir_type *type = get_entity_type(entity);
        compound_graph_path *path = new_compound_graph_path(type, len);
 
        int i = len - 1;
@@ -1952,6 +2038,17 @@ static void create_initializer_value(initializer_value_t *initializer,
        }
        assert(i == -1);
 
+       return path;
+}
+
+static void create_initializer_value(initializer_value_t *initializer,
+                                     ir_entity *entity,
+                                     compound_graph_path_entry_t *entry,
+                                     int len)
+{
+       ir_node             *node = expression_to_firm(initializer->value);
+       ir_type             *type = get_entity_type(entity);
+       compound_graph_path *path = create_compound_path(type, entry, len);
        add_compound_ent_value_w_path(entity, node, path);
 }
 
@@ -1992,9 +2089,9 @@ static void create_initializer_compound(initializer_list_t *initializer,
                        create_initializer_value((initializer_value_t*) sub_initializer,
                                                 entity, &entry, len);
                } else {
-                       assert(sub_initializer->type == INITIALIZER_LIST);
-                       create_initializer_list((initializer_list_t*) sub_initializer,
-                                               compound_entry->type, entity, &entry, len);
+                       type_t *type = skip_typeref(compound_entry->type);
+                       create_initializer_object(sub_initializer, type, entity, &entry,
+                                                 len);
                }
 
                ++i;
@@ -2007,6 +2104,7 @@ static void create_initializer_array(initializer_list_t *initializer,
                                      int len)
 {
        type_t *element_type = type->element_type;
+       element_type         = skip_typeref(element_type);
 
        compound_graph_path_entry_t entry;
        entry.type = COMPOUND_GRAPH_ENTRY_ARRAY;
@@ -2023,58 +2121,151 @@ static void create_initializer_array(initializer_list_t *initializer,
                                                 entity, &entry, len);
                } else {
                        assert(sub_initializer->type == INITIALIZER_LIST);
-                       create_initializer_list((initializer_list_t*) sub_initializer,
-                                               element_type, entity, &entry, len);
+                       create_initializer_object(sub_initializer, element_type, entity,
+                                                 &entry, len);
                }
        }
 }
 
-static void create_initializer_list(initializer_list_t *initializer,
-                                    type_t *type, ir_entity *entity,
-                                    compound_graph_path_entry_t *entry, int len)
+static void create_initializer_string(initializer_string_t *initializer,
+                                      array_type_t *type, ir_entity *entity,
+                                      compound_graph_path_entry_t *last_entry,
+                                      int len)
+{
+       type_t *element_type = type->element_type;
+       element_type         = skip_typeref(element_type);
+
+       compound_graph_path_entry_t entry;
+       entry.type = COMPOUND_GRAPH_ENTRY_ARRAY;
+       entry.prev = last_entry;
+       ++len;
+
+       ir_type    *irtype  = get_entity_type(entity);
+       size_t      arr_len = get_array_type_size(type);
+       const char *p       = initializer->string;
+       size_t      i       = 0;
+       for(i = 0; i < arr_len; ++i, ++p) {
+               entry.v.array_index = i;
+
+               ir_node             *node = new_Const_long(mode_Bs, *p);
+               compound_graph_path *path = create_compound_path(irtype, &entry, len);
+               add_compound_ent_value_w_path(entity, node, path);
+
+               if(*p == '\0')
+                       break;
+       }
+}
+
+static void create_initializer_object(initializer_t *initializer, type_t *type,
+               ir_entity *entity, compound_graph_path_entry_t *entry, int len)
 {
        if(type->type == TYPE_ARRAY) {
-               create_initializer_array(initializer, (array_type_t*) type,
-                                        entity, entry, len);
+               array_type_t *array_type = (array_type_t*) type;
+
+               if(initializer->type == INITIALIZER_STRING) {
+                       initializer_string_t *string = (initializer_string_t*) initializer;
+                       create_initializer_string(string, array_type, entity, entry, len);
+               } else {
+                       assert(initializer->type == INITIALIZER_LIST);
+                       initializer_list_t *list = (initializer_list_t*) initializer;
+                       create_initializer_array(list, array_type, entity, entry, len);
+               }
        } else {
+               assert(initializer->type == INITIALIZER_LIST);
+               initializer_list_t *list = (initializer_list_t*) initializer;
+
                assert(type->type == TYPE_COMPOUND_STRUCT
                                || type->type == TYPE_COMPOUND_UNION);
-               create_initializer_compound(initializer, (compound_type_t*) type,
-                                           entity, entry, len);
+               compound_type_t *compound_type = (compound_type_t*) type;
+               create_initializer_compound(list, compound_type, entity, entry, len);
        }
 }
 
+static void create_initializer_local_variable_entity(declaration_t *declaration)
+{
+       initializer_t *initializer = declaration->init.initializer;
+       dbg_info      *dbgi        = get_dbg_info(&declaration->source_position);
+       ir_entity     *entity      = declaration->v.entity;
+       ir_node       *memory      = get_store();
+       ir_node       *nomem       = new_NoMem();
+       ir_node       *frame       = get_irg_frame(current_ir_graph);
+       ir_node       *addr        = new_d_simpleSel(dbgi, nomem, frame, entity);
+
+       if(is_atomic_entity(entity)) {
+               assert(initializer->type == INITIALIZER_VALUE);
+               initializer_value_t *initializer_value
+                       = (initializer_value_t*) initializer;
+
+               ir_node *value     = expression_to_firm(initializer_value->value);
+               ir_node *store     = new_d_Store(dbgi, memory, addr, value);
+               ir_node *store_mem = new_d_Proj(dbgi, store, mode_M, pn_Store_M);
+               set_store(store_mem);
+               return;
+       }
+
+       /* create a "template" entity which is copied to the entity on the stack */
+       ident     *id          = unique_ident("initializer");
+       ir_type   *irtype      = get_ir_type(declaration->type);
+       ir_type   *global_type = get_glob_type();
+       ir_entity *init_entity = new_entity(global_type, id, irtype);
+       set_entity_ld_ident(init_entity, id);
+
+       set_entity_variability(init_entity, variability_initialized);
+       set_entity_visibility(init_entity, visibility_local);
+
+       ir_graph *old_current_ir_graph = current_ir_graph;
+       current_ir_graph = get_const_code_irg();
+
+       type_t *type = skip_typeref(declaration->type);
+       create_initializer_object(initializer, type, init_entity, NULL, 0);
+
+       assert(current_ir_graph == get_const_code_irg());
+       current_ir_graph = old_current_ir_graph;
+
+       ir_node *src_addr  = create_symconst(dbgi, init_entity);
+       ir_node *copyb     = new_d_CopyB(dbgi, memory, addr, src_addr, irtype);
+
+       ir_node *copyb_mem = new_Proj(copyb, mode_M, pn_CopyB_M_regular);
+       set_store(copyb_mem);
+}
+
 static void create_initializer(declaration_t *declaration)
 {
        initializer_t *initializer = declaration->init.initializer;
        if(initializer == NULL)
                return;
 
+       declaration_type_t declaration_type = (declaration_type_t)declaration->declaration_type;
+       if(declaration_type == DECLARATION_TYPE_LOCAL_VARIABLE_ENTITY) {
+               create_initializer_local_variable_entity(declaration);
+               return;
+       }
+
        if(initializer->type == INITIALIZER_VALUE) {
                initializer_value_t *initializer_value
                        = (initializer_value_t*) initializer;
                ir_node *value = expression_to_firm(initializer_value->value);
 
-               if(declaration->declaration_type == DECLARATION_TYPE_LOCAL_VARIABLE) {
+               if(declaration_type == DECLARATION_TYPE_LOCAL_VARIABLE) {
                        set_value(declaration->v.value_number, value);
                } else {
+                       assert(declaration_type == DECLARATION_TYPE_GLOBAL_VARIABLE);
+
                        ir_entity *entity = declaration->v.entity;
 
                        set_entity_variability(entity, variability_initialized);
                        set_atomic_ent_value(entity, value);
                }
        } else {
-               assert(initializer->type == INITIALIZER_LIST);
-               initializer_list_t *list = (initializer_list_t*) initializer;
-
-               declaration_type_t declaration_type = declaration->declaration_type;
+               declaration_type_t declaration_type = (declaration_type_t)declaration->declaration_type;
                assert(declaration_type == DECLARATION_TYPE_LOCAL_VARIABLE_ENTITY
                                || declaration_type == DECLARATION_TYPE_GLOBAL_VARIABLE);
 
                ir_entity *entity = declaration->v.entity;
                set_entity_variability(entity, variability_initialized);
 
-               create_initializer_list(list, declaration->type, entity, NULL, 0);
+               type_t *type = skip_typeref(declaration->type);
+               create_initializer_object(initializer, type, entity, NULL, 0);
        }
 }
 
@@ -2105,6 +2296,31 @@ static void create_local_variable(declaration_t *declaration)
        create_initializer(declaration);
 }
 
+static void create_local_static_variable(declaration_t *declaration)
+{
+       assert(declaration->declaration_type == DECLARATION_TYPE_UNKNOWN);
+
+       type_t    *type        = skip_typeref(declaration->type);
+       ir_type   *global_type = get_glob_type();
+       ident     *id          = unique_ident(declaration->symbol->string);
+       ir_type   *irtype      = get_ir_type(type);
+       ir_entity *entity      = new_entity(global_type, id, irtype);
+       set_entity_ld_ident(entity, id);
+
+       declaration->declaration_type = DECLARATION_TYPE_GLOBAL_VARIABLE;
+       declaration->v.entity         = entity;
+       set_entity_variability(entity, variability_uninitialized);
+       set_entity_visibility(entity, visibility_local);
+
+       ir_graph *old_current_ir_graph = current_ir_graph;
+       current_ir_graph = get_const_code_irg();
+
+       create_initializer(declaration);
+
+       assert(current_ir_graph == get_const_code_irg());
+       current_ir_graph = old_current_ir_graph;
+}
+
 static void declaration_statement_to_firm(declaration_statement_t *statement)
 {
        declaration_t *declaration = statement->declarations_begin;
@@ -2116,7 +2332,8 @@ static void declaration_statement_to_firm(declaration_statement_t *statement)
                case STORAGE_CLASS_TYPEDEF:
                        continue;
                case STORAGE_CLASS_STATIC:
-                       panic("static local vars not implemented yet");
+                       create_local_static_variable(declaration);
+                       continue;
                case STORAGE_CLASS_ENUM_ENTRY:
                        panic("enum entry declaration in local block found");
                case STORAGE_CLASS_EXTERN:
@@ -2237,6 +2454,8 @@ static void case_label_to_firm(const case_label_statement_t *statement)
        }
        add_immBlock_pred(block, proj);
        mature_immBlock(block);
+
+       statement_to_firm(statement->label_statement);
 }
 
 static ir_node *get_label_block(declaration_t *label)
@@ -2443,20 +2662,25 @@ static int get_function_n_local_vars(declaration_t *declaration)
        /* count local variables declared in body */
        count += count_decls_in_stmts(declaration->init.statement);
 
+       /* TODO FIXME: Matze: I'm lazy don't want to scan all expressions
+        * for expression statements... */
+       count += 10;
+
        return count;
 }
 
 static void initialize_function_parameters(declaration_t *declaration)
 {
-       ir_graph *irg         = current_ir_graph;
-       ir_node  *args        = get_irg_args(irg);
-       ir_node  *start_block = get_irg_start_block(irg);
+       ir_graph        *irg             = current_ir_graph;
+       ir_node         *args            = get_irg_args(irg);
+       ir_node         *start_block     = get_irg_start_block(irg);
+       ir_type         *function_irtype = get_ir_type(declaration->type);
 
        int            n         = 0;
        declaration_t *parameter = declaration->context.declarations;
-       for( ; parameter != NULL; parameter = parameter->next) {
+       for( ; parameter != NULL; parameter = parameter->next, ++n) {
                assert(parameter->declaration_type == DECLARATION_TYPE_UNKNOWN);
-               type_t *type = parameter->type;
+               type_t *type = skip_typeref(parameter->type);
 
                bool needs_entity = parameter->address_taken;
                if(type->type == TYPE_COMPOUND_STRUCT
@@ -2465,13 +2689,19 @@ static void initialize_function_parameters(declaration_t *declaration)
                }
 
                if(needs_entity) {
-                       panic("entities for function parameters not implemented yet");
+                       ir_entity *entity = get_method_value_param_ent(function_irtype, n);
+                       ident     *id     = new_id_from_str(parameter->symbol->string);
+                       set_entity_ident(entity, id);
+
+                       parameter->declaration_type
+                               = DECLARATION_TYPE_LOCAL_VARIABLE_ENTITY;
+                       parameter->v.entity = entity;
+                       continue;
                }
 
                ir_mode *mode = get_ir_mode(parameter->type);
                long     pn   = n;
                ir_node *proj = new_r_Proj(irg, start_block, args, mode, pn);
-               ++n;
 
                parameter->declaration_type = DECLARATION_TYPE_LOCAL_VARIABLE;
                parameter->v.value_number   = next_value_number_function;
@@ -2588,6 +2818,7 @@ static void create_global_variable(declaration_t *declaration)
 
 static void context_to_firm(context_t *context)
 {
+       /* first pass: create declarations */
        declaration_t *declaration = context->declarations;
        for( ; declaration != NULL; declaration = declaration->next) {
                if(declaration->namespc != NAMESPACE_NORMAL)
@@ -2600,11 +2831,29 @@ static void context_to_firm(context_t *context)
 
                type_t *type = declaration->type;
                if(type->type == TYPE_FUNCTION) {
-                       create_function(declaration);
+                       get_function_entity(declaration);
                } else {
                        create_global_variable(declaration);
                }
        }
+
+       /* second pass: create code */
+       declaration = context->declarations;
+       for( ; declaration != NULL; declaration = declaration->next) {
+               if(declaration->namespc != NAMESPACE_NORMAL)
+                       continue;
+               if(declaration->storage_class == STORAGE_CLASS_ENUM_ENTRY
+                               || declaration->storage_class == STORAGE_CLASS_TYPEDEF)
+                       continue;
+               if(declaration->symbol == NULL)
+                       continue;
+
+               type_t *type = declaration->type;
+               if(type->type != TYPE_FUNCTION)
+                       continue;
+
+               create_function(declaration);
+       }
 }
 
 void translation_unit_to_firm(translation_unit_t *unit)